From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7587: 23.2; `format-mode-line' makes Emacs crash Date: Mon, 20 Dec 2010 20:33:22 +0200 Message-ID: <83d3owfg5p.fsf@gnu.org> References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> <87ei9icvg0.fsf@stupidchicken.com> <83r5dffoi5.fsf@gnu.org> <87y67k1mz7.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1292871187 30219 80.91.229.12 (20 Dec 2010 18:53:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 20 Dec 2010 18:53:07 +0000 (UTC) Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 20 19:53:00 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PUkqx-0003tE-Vm for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Dec 2010 19:53:00 +0100 Original-Received: from localhost ([127.0.0.1]:35588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUkqx-0002l0-HB for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Dec 2010 13:52:59 -0500 Original-Received: from [140.186.70.92] (port=55289 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUkqt-0002kg-3P for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2010 13:52:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PUkqr-0003Uq-QB for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2010 13:52:54 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PUkqr-0003Uh-LW for bug-gnu-emacs@gnu.org; Mon, 20 Dec 2010 13:52:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PUkUl-0004aK-OH; Mon, 20 Dec 2010 13:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Dec 2010 18:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7587-submit@debbugs.gnu.org id=B7587.129286974817537 (code B ref 7587); Mon, 20 Dec 2010 18:30:03 +0000 Original-Received: (at 7587) by debbugs.gnu.org; 20 Dec 2010 18:29:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PUkTr-0004Yo-NF for submit@debbugs.gnu.org; Mon, 20 Dec 2010 13:29:07 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PUkTo-0004YK-Rm for 7587@debbugs.gnu.org; Mon, 20 Dec 2010 13:29:06 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LDQ00200OY0LL00@a-mtaout22.012.net.il> for 7587@debbugs.gnu.org; Mon, 20 Dec 2010 20:35:26 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.167.122]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LDQ0007OOZ0MFJ0@a-mtaout22.012.net.il>; Mon, 20 Dec 2010 20:35:26 +0200 (IST) In-reply-to: <87y67k1mz7.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 20 Dec 2010 13:30:03 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42673 Archived-At: > From: Chong Yidong > Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org > Date: Mon, 20 Dec 2010 23:29:48 +0800 > > I mean, format-mode-line with a non-nil FACE argument doesn't seem to be > used anywhere. Not in Emacs sources, no. But it's a feature that some application could plausibly want. > > Given some history of discussions here, and the fact that no one seems > > to be sure how this code should really work and why, I wonder why you > > went ahead with the change without discussing it first. I'm afraid > > that this change breaks backward compatibility for no good reason. > > Given that the backward compatible behavior is to segfault, this > breakage might be acceptable. It only crashed if some faces were remapped, otherwise it would "just work". (And it isn't a segfault, it's a deliberate call to `abort'.) > Less flippantly, the FACE argument, if non-nil, is still applied as a > text property to the returned string. Which makes me wonder why we need to pass to init_iterator anything but DEFAULT_FACE_ID... > So I don't think there's going to be any noticeable difference > (again, we don't have any concrete use cases, so it's difficult to > say). The docstring change might not even be necessary. If FACE is still applied, then the doc string change (and part of what I wrote in NEWS and the ELisp manual) should indeed be reverted.