bug#8595: 24.0.50; cannot send bug report with emacs -nw

bug#8595: 24.0.50; cannot send bug report with emacs -nw

[Drew Adams]

When I hit C-c C-c to send the bug-report mail, instead of Emacs popping
up my mail client with a new message, and allowing me to paste the
bug-report contents into the mail, all that happens is that I see
"Sending...failed with exit value 1".
 
And I see buffer *unsent mail to bug-gnu-emacs@gnu.org* with my mail.
In that buffer, the From field says this:
dradams@DRADAMS-LAP1.i-did-not-set--mail-host-address--so-tickle-me
 
And the Message-ID field says this:
 
<krysjszhgw8.fsf@DRADAMS-LAP1.i-did-not-set--mail-host-address--so-tickle-me>
 
emacs -nw -Q should work the same way as emacs -Q for sending a bug
report.  On Windows it should pop up a new mail message using the user's
mail client (in my case Outlook) and let the user paste the bug-report
content from Emacs into to the new message.
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-04-25 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/imagesupport/include'
 

bug#8595: 24.0.50; cannot send bug report with emacs -nw

[Eli Zaretskii]

> From: "Drew Adams" <drew.adams@oracle.com>
> Date: Sat, 30 Apr 2011 09:01:33 -0700
> 
> When I hit C-c C-c to send the bug-report mail, instead of Emacs popping
> up my mail client with a new message, and allowing me to paste the
> bug-report contents into the mail, all that happens is that I see
> "Sending...failed with exit value 1".

What is your value of send-mail-function in the session that fails
like that?

bug#8595: 24.0.50; cannot send bug report with emacs -nw

[Drew Adams]

> What is your value of send-mail-function in the session that fails
> like that?

send-mail-function is a variable defined in `sendmail.el'.
Its value is sendmail-send-it

bug#8595: 24.0.50; cannot send bug report with emacs -nw

[Eli Zaretskii]

> From: "Drew Adams" <drew.adams@oracle.com>
> Cc: <8595@debbugs.gnu.org>
> Date: Sat, 30 Apr 2011 10:51:04 -0700
> 
> > What is your value of send-mail-function in the session that fails
> > like that?
> 
> send-mail-function is a variable defined in `sendmail.el'.
> Its value is sendmail-send-it

That's the culprit, it should be mailclient-send-t.  I will try to
figure out why it doesn't happen in "emacs -nw".

bug#8595: 24.0.50; cannot send bug report with emacs -nw

[Andy Moreton]

On Sat 30 Apr 2011, Eli Zaretskii wrote:

>> From: "Drew Adams" <drew.adams@oracle.com>
>> Cc: <8595@debbugs.gnu.org>
>> Date: Sat, 30 Apr 2011 10:51:04 -0700
>> 
>> > What is your value of send-mail-function in the session that fails
>> > like that?
>> 
>> send-mail-function is a variable defined in `sendmail.el'.
>> Its value is sendmail-send-it
>
> That's the culprit, it should be mailclient-send-t.  I will try to
> figure out why it doesn't happen in "emacs -nw".

Looking in sendmail.el:
--8<---------------cut here---------------start------------->8---
;; Prevent problems with `window-system' not having the correct value
;; when loaddefs.el is loaded. `custom-reevaluate-setting' needs the
;; standard value.
;;;###autoload
(put 'send-mail-function 'standard-value
     '((if (and window-system (memq system-type '(darwin windows-nt)))
	   'mailclient-send-it
	 'sendmail-send-it)))

;; Useful to set in site-init.el
;;;###autoload
(defcustom send-mail-function
  (if (and window-system (memq system-type '(darwin windows-nt)))
      'mailclient-send-it
    'sendmail-send-it)
--8<---------------cut here---------------end--------------->8---

So the question seems to be why is mailclient-send-it preferred only
when window-system is non-nil ?

    AndyM

bug#8595: 24.0.50; cannot send bug report with emacs -nw

[Eli Zaretskii]

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sun, 01 May 2011 18:11:10 +0100
> 
> So the question seems to be why is mailclient-send-it preferred only
> when window-system is non-nil ?

Probably because text terminals cannot access the clipboard, whereas
mailclient-send-it calls clipboard-kill-ring-save.  But the MS-Windows
build still can access the clipboard even under -nw, so that condition
needs to be revised.

bug#8595: 24.0.50; cannot send bug report with emacs -nw

[Eli Zaretskii]

> Date: Sun, 01 May 2011 20:43:40 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: bug-gnu-emacs@gnu.org
> 
> > From: Andy Moreton <andrewjmoreton@gmail.com>
> > Date: Sun, 01 May 2011 18:11:10 +0100
> > 
> > So the question seems to be why is mailclient-send-it preferred only
> > when window-system is non-nil ?
> 
> Probably because text terminals cannot access the clipboard, whereas
> mailclient-send-it calls clipboard-kill-ring-save.  But the MS-Windows
> build still can access the clipboard even under -nw, so that condition
> needs to be revised.

Done (revno 104157 on the trunk).