From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: linum.el: problem (bug ?) fix and improvement Date: Thu, 12 May 2011 20:21:00 +0300 Message-ID: <83d3jnhm2r.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1305220994 20525 80.91.229.12 (12 May 2011 17:23:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 12 May 2011 17:23:14 +0000 (UTC) Cc: t_tuneyosi@hotmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 12 19:23:10 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QKZbR-0000xD-Qy for ged-emacs-devel@m.gmane.org; Thu, 12 May 2011 19:23:09 +0200 Original-Received: from localhost ([::1]:52770 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKZbR-0002Cg-1u for ged-emacs-devel@m.gmane.org; Thu, 12 May 2011 13:23:09 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:38869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKZbO-0002Ca-M7 for emacs-devel@gnu.org; Thu, 12 May 2011 13:23:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QKZbN-00045Y-I5 for emacs-devel@gnu.org; Thu, 12 May 2011 13:23:06 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:59883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKZbN-00045O-8u for emacs-devel@gnu.org; Thu, 12 May 2011 13:23:05 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LL300400ERXE200@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 12 May 2011 20:23:03 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.91.65]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LL3003AKEYEHWD0@a-mtaout22.012.net.il>; Thu, 12 May 2011 20:23:03 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139330 Archived-At: > From: Stefan Monnier > Date: Thu, 12 May 2011 10:58:58 -0300 > Cc: emacs-devel@gnu.org > > What we'd like here is for the redisplay to ignore the margin property > placed on invisible text. Are you sure? Only part of a line could be invisible, in which case it won't be easy to explain why we drop the before-string on the floor. I would be uneasy to make such radical changes on behalf of a single use case. > This boils down to making Emacs ignore > `before-string' properties placed at the beginning of invisible text. > I don't think it's always right to ignore them, tho. There's explicit code to do it the way we do now: /* If there are before-strings at the start of invisible text, and the text is invisible because of a text property, arrange to show before-strings because 20.x did it that way. (If the text is invisible because of an overlay property instead of a text property, this is already handled in the overlay code.) */ if (NILP (overlay) && get_overlay_strings (it, it->stop_charpos)) { handled = HANDLED_RECOMPUTE_PROPS; it->stack[it->sp - 1].display_ellipsis_p = display_ellipsis_p; } Just undoing this would be regression from Emacs 20.x.