all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: oslsachem <oslsachem@gmail.com>
Cc: 8562@debbugs.gnu.org
Subject: bug#8562: Emacs 23.1 and later don't work in windows 98
Date: Sat, 01 Oct 2011 14:06:25 +0300	[thread overview]
Message-ID: <83d3ehc6oe.fsf@gnu.org> (raw)
In-Reply-To: <BANLkTimJmrP55gJ6yhd=sKy+-N1ztpj1HA@mail.gmail.com>

> Date: Sun, 12 Jun 2011 23:47:33 +0200
> From: oslsachem <oslsachem@gmail.com>
> Cc: 8562@debbugs.gnu.org
> 
> So the change correctly done (supposing the is_windows_9x() function
> was available for this file) could be something like :
> 
> void
> globals_of_w32menu ()
> {
>   /* See if Get/SetMenuItemInfo functions are available.  */
>   HMODULE user32 = GetModuleHandle ("user32.dll");
>   get_menu_item_info = (GetMenuItemInfoA_Proc) GetProcAddress (user32,
> "GetMenuItemInfoA");
>   set_menu_item_info = (SetMenuItemInfoA_Proc) GetProcAddress (user32,
> "SetMenuItemInfoA");
>   if (is_windows_9x())
>     {
>       HMODULE unicows = GetModuleHandle ("unicows.dll");
>       unicode_append_menu = (AppendMenuW_Proc) GetProcAddress
> (unicows, "AppendMenuW");
>     }
>   else unicode_append_menu = (AppendMenuW_Proc) GetProcAddress
> (user32, "AppendMenuW");
> }
> 
> I think it would be interesting to make this change given that this
> unicode function is already called through function pointers and that
> this would keep the execution branches of windows 9x and windows NT as
> close as possible.

I would like to avoid making changes for which we don't have a good
reason and a clear test case.  So if you can spot any significant
differences in menus depending on whether AppendMenuW comes from
unicows.dll or elsewhere, please show them, and let's take it from
there.  If there are no significant differences, I'd prefer not to
rock the boat more than necessary.

Thanks.





  reply	other threads:[~2011-10-01 11:06 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 21:55 bug#8562: Emacs 23.1 and later don't work in windows 98 oslsachem
2011-04-27  3:09 ` Eli Zaretskii
2011-05-06  1:38   ` oslsachem
2011-05-06 11:52     ` Eli Zaretskii
2011-05-06 15:28       ` Eli Zaretskii
2011-05-22 21:32       ` oslsachem
2011-05-23 13:43         ` Jason Rumney
2011-05-24 19:31           ` oslsachem
2011-05-23 17:39         ` Eli Zaretskii
2011-05-24 19:32           ` oslsachem
2011-05-24 20:37             ` Eli Zaretskii
2011-05-25  2:01               ` oslsachem
2011-05-25  4:28                 ` Eli Zaretskii
2011-05-25 10:53                   ` oslsachem
2011-05-25 16:44                     ` Eli Zaretskii
2011-05-26  1:50                       ` oslsachem
2011-05-27 14:04                         ` Eli Zaretskii
2011-05-27 17:22                           ` oslsachem
2011-05-27 18:17                             ` Eli Zaretskii
2011-05-27 16:13                         ` oslsachem
2011-05-27 17:15                           ` Eli Zaretskii
2011-05-27 18:33                             ` oslsachem
2011-05-27 20:51                               ` Eli Zaretskii
2011-05-30 15:12                                 ` oslsachem
2011-05-30 18:43                                   ` Eli Zaretskii
2011-05-31 18:16                                     ` oslsachem
2011-05-31 21:02                                       ` Eli Zaretskii
2011-05-31 21:04                                       ` Eli Zaretskii
2011-06-02 23:41                                         ` oslsachem
2011-06-03  7:10                                           ` Eli Zaretskii
2011-06-03  8:29                                           ` Eli Zaretskii
2011-06-03 20:10                                             ` oslsachem
2011-06-03 20:51                                               ` oslsachem
2011-06-03 22:52                                                 ` oslsachem
2011-06-04  7:11                                                   ` Eli Zaretskii
2011-06-05  1:58                                                     ` oslsachem
2011-06-05  3:07                                                       ` Eli Zaretskii
2011-06-05  5:48                                                         ` Eli Zaretskii
2011-06-05 22:32                                                         ` oslsachem
2011-06-07 19:25                                                           ` oslsachem
2011-06-07 20:32                                                             ` Eli Zaretskii
2011-06-08 18:11                                                               ` oslsachem
2011-06-08 20:36                                                                 ` Eli Zaretskii
2011-06-12 21:47                                                               ` oslsachem
2011-10-01 11:06                                                                 ` Eli Zaretskii [this message]
2011-10-26 23:05                                                                   ` oslsachem
2011-10-01 11:03                                                               ` Eli Zaretskii
2011-10-26 22:46                                                                 ` oslsachem
2011-10-27 14:53                                                                   ` Eli Zaretskii
     [not found]                                                                     ` <CADv-x1szHOjvVzg8xAYtZNE4iByugKeQz37SY+-dNVucioB70w@mail.gmail.com>
2011-10-28 10:21                                                                       ` Eli Zaretskii
2011-10-28 12:11                                                                         ` Eli Zaretskii
2011-10-29 22:24                                                                           ` oslsachem
2011-11-04 11:42                                                                             ` Eli Zaretskii
2011-11-04 20:59                                                                               ` oslsachem
2011-11-04 22:01                                                                                 ` Eli Zaretskii
2011-10-28 10:10                                                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d3ehc6oe.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=8562@debbugs.gnu.org \
    --cc=oslsachem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.