From: Eli Zaretskii <eliz@gnu.org>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: 12159@debbugs.gnu.org
Subject: bug#12159: 24.1.50; vc-dir: Need a way to hide unregistered files
Date: Sun, 12 Aug 2012 22:20:29 +0300 [thread overview]
Message-ID: <83d32v7w8y.fsf@gnu.org> (raw)
In-Reply-To: <87zk60hqnv.fsf@gmail.com>
> From: Jambunathan K <kjambunathan@gmail.com>
> Date: Mon, 13 Aug 2012 00:41:00 +0530
> Cc: 12159@debbugs.gnu.org
>
> I wish reviewers provide feedback which is comprehensive right from the
> word go. Let me explain ...
>
> When I submitted my patch it was complete i.e., I did not present it
> hunk-by-hunk. I re-worked the patch based on feedback and I have
> demonstrated some seriousness in making the patch acceptable.
>
> Unfortunately, the review process here seems to have gone by "hunk by
> hunk" mode. A small note here, a small note there. For something as
> simple as this patch, why should we have 100 exchanges?
>
> I can't care less if you call my patch a crap or hold an opinion that I
> should never enter a programmer's territory. It is not what I am
> talking about.
>
> Reviewers have infinite time to review the patch. Let them collect
> their notes and give a comprehensive list of what they think is
> acceptable to them.
>
> I hope I am not placing an un-reasonable demand.
>
> We are talking of an implicit social contract that reviewers and patch
> submitters should adhere to. Unfortunately, it is only the patch
> submitters end of the contract that gets much emphasis.
I'm sorry you feel this way. However, after reading the entire
discussion, I see nothing but a reasonable process. Let me explain.
Your original submission first got a general comment from Stefan
suggesting a different approach. When you reworked the patch
according to Stefan's suggestions, you got one comment from Andreas
(with whom you exchanged a couple of messages regarding his comment),
and several specific comments from Stefan. It is entirely reasonable
that two different people comment on different portions of the patch.
Sorry, but I see no "hunk by hunk" here.
next prev parent reply other threads:[~2012-08-12 19:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 18:07 bug#12159: 24.1.50; vc-dir: Need a way to hide unregistered files Jambunathan K
2012-08-08 18:27 ` Glenn Morris
2012-08-08 18:52 ` Jambunathan K
2012-08-09 1:54 ` Stefan Monnier
2012-08-11 17:41 ` Jambunathan K
2012-08-11 22:40 ` Stefan Monnier
2012-08-12 1:50 ` Jambunathan K
2012-08-12 7:37 ` Andreas Schwab
2012-08-12 9:58 ` Jambunathan K
2012-08-12 10:02 ` Andreas Schwab
2012-08-12 11:04 ` Jambunathan K
2012-08-12 14:07 ` Andreas Schwab
2012-08-12 14:13 ` Stefan Monnier
2012-08-12 14:22 ` Jambunathan K
2012-08-12 19:11 ` Jambunathan K
2012-08-12 19:20 ` Eli Zaretskii [this message]
2012-08-12 19:40 ` Jambunathan K
2012-08-13 14:21 ` Bastien
2012-08-12 22:35 ` Stefan Monnier
2012-08-13 17:46 ` Jambunathan K
2012-08-13 21:34 ` Stefan Monnier
2012-08-13 22:09 ` Bastien
2012-08-14 4:28 ` Jambunathan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d32v7w8y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12159@debbugs.gnu.org \
--cc=kjambunathan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.