From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12196: 24.1.50; setting cache-long-line-scans to non-nil freezes Emacs Date: Mon, 10 Sep 2012 20:10:33 +0300 Message-ID: <83d31tls6u.fsf@gnu.org> References: <87has6ysxn.fsf@web.de> <834no4jeoa.fsf@gnu.org> <87ehmwscrt.fsf@web.de> <83ehmwh0pn.fsf@gnu.org> <87sjb9g981@ch.ristopher.com> <83oblrqwc1.fsf@gnu.org> <877gs218a3@ch.ristopher.com> <83ligikuam.fsf@gnu.org> <87mx0y9fss@ch.ristopher.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1347297098 8818 80.91.229.3 (10 Sep 2012 17:11:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Sep 2012 17:11:38 +0000 (UTC) Cc: 12196@debbugs.gnu.org To: Christopher Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 10 19:11:38 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TB7WI-00086m-IK for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Sep 2012 19:11:34 +0200 Original-Received: from localhost ([::1]:36753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB7WF-0005Qi-3S for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Sep 2012 13:11:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB7WC-0005QX-4H for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2012 13:11:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TB7WA-0001PF-Ls for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2012 13:11:28 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB7WA-0001PA-IV for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2012 13:11:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TB7Wj-00064V-Ve for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2012 13:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Sep 2012 17:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12196 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.134729707223278 (code B ref -1); Mon, 10 Sep 2012 17:12:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Sep 2012 17:11:12 +0000 Original-Received: from localhost ([127.0.0.1]:52622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TB7Vu-00063N-Hd for submit@debbugs.gnu.org; Mon, 10 Sep 2012 13:11:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51594) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TB7Vr-00063G-U4 for submit@debbugs.gnu.org; Mon, 10 Sep 2012 13:11:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TB7VH-00012S-58 for submit@debbugs.gnu.org; Mon, 10 Sep 2012 13:10:32 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:46259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB7VH-00012O-20 for submit@debbugs.gnu.org; Mon, 10 Sep 2012 13:10:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB7VG-0005Ml-2I for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2012 13:10:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TB7VE-00011Z-Ow for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2012 13:10:30 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:56767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB7VE-0000zO-Fq for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2012 13:10:28 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MA5002008X43V00@a-mtaout21.012.net.il> for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2012 20:10:26 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MA5001CO91DYD60@a-mtaout21.012.net.il>; Mon, 10 Sep 2012 20:10:26 +0300 (IDT) In-reply-to: <87mx0y9fss@ch.ristopher.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64063 Archived-At: > From: Christopher Schmidt > Cc: bug-gnu-emacs@gnu.org > Date: Mon, 10 Sep 2012 14:19:00 +0100 (BST) > > Eli Zaretskii writes: > > Thanks. Does the patch below help? > > === modified file 'src/search.c' > > --- src/search.c 2012-09-04 17:34:54 +0000 > > +++ src/search.c 2012-09-10 11:07:13 +0000 > > @@ -681,10 +681,11 @@ scan_buffer (register int target, ptrdif > > to see where we can avoid some scanning. */ > > if (target == '\n' && newline_cache) > > { > > - ptrdiff_t next_change; > > + ptrdiff_t next_change = 0; > > immediate_quit = 0; > > while (region_cache_forward > > - (current_buffer, newline_cache, start_byte, &next_change)) > > + (current_buffer, newline_cache, start_byte, &next_change) > > + || next_change == Z) > > start_byte = next_change; > > immediate_quit = allow_quit; > > Unfortunately it does not. How about the one below? Once again, a reproducible recipe with buffer text that causes the infloop would help immensely, TIA. === modified file 'src/search.c' --- src/search.c 2012-09-04 17:34:54 +0000 +++ src/search.c 2012-09-10 17:06:46 +0000 @@ -666,7 +666,7 @@ scan_buffer (register int target, ptrdif immediate_quit = allow_quit; if (count > 0) - while (start != end) + while (start < end) { /* Our innermost scanning loop is very simple; it doesn't know about gaps, buffer ends, or the newline cache. ceiling is