From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12541: Prefer plain 'static' to 'static inline'. Date: Sun, 30 Sep 2012 11:49:46 +0200 Message-ID: <83d313et6t.fsf@gnu.org> References: <5067FC19.3000704@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1348998648 15256 80.91.229.3 (30 Sep 2012 09:50:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2012 09:50:48 +0000 (UTC) Cc: 12541@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 30 11:50:53 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIGAm-0004o1-Kf for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2012 11:50:52 +0200 Original-Received: from localhost ([::1]:41162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIGAg-0003Yj-Rs for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2012 05:50:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIGAd-0003YT-La for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 05:50:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIGAc-0000RM-G6 for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 05:50:43 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIGAc-0000RH-CG for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 05:50:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TIGAv-0007Q9-NN for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 05:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Sep 2012 09:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12541-submit@debbugs.gnu.org id=B12541.134899864028494 (code B ref 12541); Sun, 30 Sep 2012 09:51:01 +0000 Original-Received: (at 12541) by debbugs.gnu.org; 30 Sep 2012 09:50:40 +0000 Original-Received: from localhost ([127.0.0.1]:34068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIGAZ-0007PX-D9 for submit@debbugs.gnu.org; Sun, 30 Sep 2012 05:50:40 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:63240) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIGAW-0007PO-FZ for 12541@debbugs.gnu.org; Sun, 30 Sep 2012 05:50:37 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MB500100PJJ2P00@a-mtaout22.012.net.il> for 12541@debbugs.gnu.org; Sun, 30 Sep 2012 11:49:43 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MB50002KPYUSL80@a-mtaout22.012.net.il>; Sun, 30 Sep 2012 11:49:42 +0200 (IST) In-reply-to: <5067FC19.3000704@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65022 Archived-At: > Date: Sun, 30 Sep 2012 01:00:25 -0700 > From: Paul Eggert > > This one should be pretty self-explanatory. > > === modified file 'src/ChangeLog' > --- src/ChangeLog 2012-09-30 07:26:32 +0000 > +++ src/ChangeLog 2012-09-30 07:57:28 +0000 > @@ -1,3 +1,98 @@ > +2012-09-30 Paul Eggert > + > + Prefer plain 'static' to 'static inline'. > + With static functions, modern compilers inline pretty well by > + themselves; advice from programmers often hurts as much as it helps. > + On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'), > + this change shrinks the text size of the Emacs executable by 1.7% > + without affecting CPU significantly in my benchmark. Since what version of GCC we can trust that static functions are inlined? The inline functions in bidi.c _must_ be inlined for performance reasons. If the only way to make sure they are is to make them external, then so be it.