From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 12541@debbugs.gnu.org
Subject: bug#12541: Prefer plain 'static' to 'static inline'.
Date: Sun, 30 Sep 2012 11:49:46 +0200 [thread overview]
Message-ID: <83d313et6t.fsf@gnu.org> (raw)
In-Reply-To: <5067FC19.3000704@cs.ucla.edu>
> Date: Sun, 30 Sep 2012 01:00:25 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
>
> This one should be pretty self-explanatory.
>
> === modified file 'src/ChangeLog'
> --- src/ChangeLog 2012-09-30 07:26:32 +0000
> +++ src/ChangeLog 2012-09-30 07:57:28 +0000
> @@ -1,3 +1,98 @@
> +2012-09-30 Paul Eggert <eggert@cs.ucla.edu>
> +
> + Prefer plain 'static' to 'static inline'.
> + With static functions, modern compilers inline pretty well by
> + themselves; advice from programmers often hurts as much as it helps.
> + On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
> + this change shrinks the text size of the Emacs executable by 1.7%
> + without affecting CPU significantly in my benchmark.
Since what version of GCC we can trust that static functions are
inlined?
The inline functions in bidi.c _must_ be inlined for performance
reasons. If the only way to make sure they are is to make them
external, then so be it.
next prev parent reply other threads:[~2012-09-30 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 8:00 bug#12541: Prefer plain 'static' to 'static inline' Paul Eggert
2012-09-30 9:49 ` Eli Zaretskii [this message]
2012-09-30 14:18 ` Jason Rumney
2012-09-30 15:57 ` Eli Zaretskii
2012-09-30 17:58 ` Paul Eggert
2012-09-30 18:33 ` Eli Zaretskii
2012-09-30 18:48 ` Paul Eggert
2012-10-01 6:38 ` Paul Eggert
2012-10-01 17:14 ` Eli Zaretskii
2012-10-02 7:00 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d313et6t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12541@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.