From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12931: a bug in Emacs for Windows (win32fns.c: x-file-dialog) Date: Mon, 19 Nov 2012 21:08:02 +0200 Message-ID: <83d2z9xvfx.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1353352147 31708 80.91.229.3 (19 Nov 2012 19:09:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2012 19:09:07 +0000 (UTC) Cc: 12931@debbugs.gnu.org To: Du Yanning Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 19 20:09:18 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TaWib-0003N3-Pl for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Nov 2012 20:09:17 +0100 Original-Received: from localhost ([::1]:53895 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaWiR-0007T7-G7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Nov 2012 14:09:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaWiM-0007T0-8q for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2012 14:09:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaWiH-0007Vw-Ib for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2012 14:09:01 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaWiH-0007Vs-F2 for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2012 14:08:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TaWjK-0005sC-56 for bug-gnu-emacs@gnu.org; Mon, 19 Nov 2012 14:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Nov 2012 19:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12931 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12931-submit@debbugs.gnu.org id=B12931.135335217522537 (code B ref 12931); Mon, 19 Nov 2012 19:10:02 +0000 Original-Received: (at 12931) by debbugs.gnu.org; 19 Nov 2012 19:09:35 +0000 Original-Received: from localhost ([127.0.0.1]:55488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TaWis-0005rS-Lj for submit@debbugs.gnu.org; Mon, 19 Nov 2012 14:09:34 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:41805) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TaWip-0005rI-Gk for 12931@debbugs.gnu.org; Mon, 19 Nov 2012 14:09:32 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MDR006000ODDD00@a-mtaout23.012.net.il> for 12931@debbugs.gnu.org; Mon, 19 Nov 2012 21:08:24 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MDR0061P160C950@a-mtaout23.012.net.il>; Mon, 19 Nov 2012 21:08:24 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67175 Archived-At: > Date: Mon, 19 Nov 2012 21:53:02 +0800 > From: Du Yanning > > x-file-dialog uses GetOpenFileName to get a file name. > If you have a buffer that is not visiting any file, when you call > save-buffer through a tool-bar button, x-file-dialog gets called. > However, with GetOpenFileName, you must select an existing file. > > We can fix this bug by minimum change. > > in x-file-dialog (defined in win32fns.c) > > change the line: > > file_opened = GetOpenFileName (file_details); > > to > > if (!NILP (mustmatch)) > { > file_opened = GetOpenFileName (file_details); > } > else > { > file_opened = GetSaveFileName (file_details); > } Thanks. However, looking at the current code, I see this: file_details->Flags = (OFN_HIDEREADONLY | OFN_NOCHANGEDIR | OFN_EXPLORER | OFN_ENABLEHOOK); if (!NILP (mustmatch)) { /* Require that the path to the parent directory exists. */ file_details->Flags |= OFN_PATHMUSTEXIST; /* If we are looking for a file, require that it exists. */ if (NILP (only_dir_p)) file_details->Flags |= OFN_FILEMUSTEXIST; } which means that the OFN_FILEMUSTEXIST and OFN_PATHMUSTEXIST flags are _not_ set if mustmatch is nil. Are you saying that GetOpenFileName requires the file to exist, even though these flags are not set? This seems to contradict the MSDN documentation at http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839%28v=vs.85%29.aspx Or are you saying that the mustmatch flag is set incorrectly when the buffer is not visiting a file?