From: Eli Zaretskii <eliz@gnu.org>
To: Du Yanning <duyanning@gmail.com>
Cc: 12931@debbugs.gnu.org
Subject: bug#12931: a bug in Emacs for Windows (win32fns.c: x-file-dialog)
Date: Mon, 19 Nov 2012 21:08:02 +0200 [thread overview]
Message-ID: <83d2z9xvfx.fsf@gnu.org> (raw)
In-Reply-To: <CALr_ej1OfgGya33i67C8NWGxLNxYZ+reRUMw-xmw7zKyXA03Fg@mail.gmail.com>
> Date: Mon, 19 Nov 2012 21:53:02 +0800
> From: Du Yanning <duyanning@gmail.com>
>
> x-file-dialog uses GetOpenFileName to get a file name.
> If you have a buffer that is not visiting any file, when you call
> save-buffer through a tool-bar button, x-file-dialog gets called.
> However, with GetOpenFileName, you must select an existing file.
>
> We can fix this bug by minimum change.
>
> in x-file-dialog (defined in win32fns.c)
>
> change the line:
>
> file_opened = GetOpenFileName (file_details);
>
> to
>
> if (!NILP (mustmatch))
> {
> file_opened = GetOpenFileName (file_details);
> }
> else
> {
> file_opened = GetSaveFileName (file_details);
> }
Thanks. However, looking at the current code, I see this:
file_details->Flags = (OFN_HIDEREADONLY | OFN_NOCHANGEDIR
| OFN_EXPLORER | OFN_ENABLEHOOK);
if (!NILP (mustmatch))
{
/* Require that the path to the parent directory exists. */
file_details->Flags |= OFN_PATHMUSTEXIST;
/* If we are looking for a file, require that it exists. */
if (NILP (only_dir_p))
file_details->Flags |= OFN_FILEMUSTEXIST;
}
which means that the OFN_FILEMUSTEXIST and OFN_PATHMUSTEXIST flags are
_not_ set if mustmatch is nil. Are you saying that GetOpenFileName
requires the file to exist, even though these flags are not set? This
seems to contradict the MSDN documentation at
http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839%28v=vs.85%29.aspx
Or are you saying that the mustmatch flag is set incorrectly when the
buffer is not visiting a file?
next prev parent reply other threads:[~2012-11-19 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 13:53 bug#12931: a bug in Emacs for Windows (win32fns.c: x-file-dialog) Du Yanning
2012-11-19 19:08 ` Eli Zaretskii [this message]
[not found] ` <CALr_ej2asGEUoTkBRPyryMMm7dFVtmYuixPt+nuXoPV+gYs0sw@mail.gmail.com>
2012-11-20 16:18 ` Eli Zaretskii
2014-02-06 1:38 ` Lars Ingebrigtsen
2014-02-06 6:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d2z9xvfx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12931@debbugs.gnu.org \
--cc=duyanning@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.