From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs24 coding system problems Date: Sun, 25 Nov 2012 18:06:12 +0200 Message-ID: <83d2z1zmyz.fsf@gnu.org> References: <20627.33570.796000.901596@gargle.gargle.HOWL> <20649.12724.125000.858979@gargle.gargle.HOWL> <83k3tizkl2.fsf@gnu.org> <20649.61758.750000.69012@gargle.gargle.HOWL> <20657.53134.989000.793074@gargle.gargle.HOWL> <20657.63114.521000.806863@gargle.gargle.HOWL> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1353859570 3335 80.91.229.3 (25 Nov 2012 16:06:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 25 Nov 2012 16:06:10 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Uday Reddy Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 25 17:06:22 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tceis-00022o-2i for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2012 17:06:22 +0100 Original-Received: from localhost ([::1]:39012 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tceig-0004Lu-QI for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2012 11:06:10 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tceie-0004Lb-1O for emacs-devel@gnu.org; Sun, 25 Nov 2012 11:06:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tceic-0001Q9-T8 for emacs-devel@gnu.org; Sun, 25 Nov 2012 11:06:07 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:49623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tceic-0001Q3-Ku for emacs-devel@gnu.org; Sun, 25 Nov 2012 11:06:06 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0ME100200WPWOL00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Sun, 25 Nov 2012 18:06:04 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ME1002JWWQ3I380@a-mtaout21.012.net.il>; Sun, 25 Nov 2012 18:06:04 +0200 (IST) In-reply-to: <20657.63114.521000.806863@gargle.gargle.HOWL> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155079 Archived-At: > Date: Sun, 25 Nov 2012 10:44:26 +0000 > From: Uday Reddy > Cc: Stefan Monnier , emacs-devel@gnu.org > > False alarm. I managed to get the trunk to build on Win32. I'm confused: is this problem specific to MS-Windows? I don't think you ever mentioned Windows in this thread before; did I miss something? > I can't get the revision 103292 to compile. It gave an error > > xdisp.c: In function 'decode_mode_spec': > xdisp.c:19589:14: error: 'buffer_file_type' undeclared (first use in this functi > on) > xdisp.c:19589:14: note: each undeclared identifier is reported only once for eac > h function it appears in > mingw32-make[2]: *** [oo-spd/i386/xdisp.o] Error 1 > > I am trying the neighbouring revisions. Uday, this isn't the most efficient way of finding the bug. It will waste a lot of your time and energy on overcoming unrelated problems, especially since 103292 is such a mega-changeset. The most efficient way is to debug the _current_ codebase. Not to go back to prior versions, but go forward. We are not interested in finding bugs in past versions, we are interested in finding current (and future ;-) bugs. So let's revisit your last finding. You said: > Tracing through find-file-noselect-1, I found that `rawfile' was set to > nil. Then there is call to `insert-file-contents'. When it returns, > enable-multibyte-characters has been set to nil. The logical next step is to find out what happened during the call to insert-file-contents. The most probable suspect is the call to the function after-insert-file-set-coding. insert-file-contents calls it after reading the file into a buffer, in order to find the appropriate coding-system to set the buffer's buffer-file-coding-system. Can you see what happens inside after-insert-file-set-coding?