all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 13125@debbugs.gnu.org, cyd@gnu.org
Subject: bug#13125: Fix permissions bugs with setgid directories etc.
Date: Sun, 09 Dec 2012 19:03:04 +0200	[thread overview]
Message-ID: <83d2yjcg53.fsf@gnu.org> (raw)
In-Reply-To: <50C43D23.8070507@cs.ucla.edu>

> Date: Sat, 08 Dec 2012 23:26:27 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: 13125@debbugs.gnu.org
> 
> On 12/08/2012 07:54 PM, Chong Yidong wrote:
> > Have you actually done a survey of all the callers to file-attributes to
> > see if this is true?
> 
> Yes, all the callers that are distributed as part of Emacs.

Did you find _any_ of them that even reference this attribute?  I
didn't, but perhaps I missed something.

Given the "wide" use, it is hard to reason what should be the value of
this attribute after these changes are installed.  You set them to
zero, which is neither nil nor t; thus, code that was testing for
either of these two values explicitly will now fail, while code that
was testing for non-nil will succeed where perhaps it shouldn't have.
For these reasons, I would suggest to leave the value at one of these
two, whichever is more frequent in real life.





  reply	other threads:[~2012-12-09 17:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-09  1:13 bug#13125: Fix permissions bugs with setgid directories etc Paul Eggert
2012-12-09  3:54 ` Chong Yidong
2012-12-09  7:26   ` Paul Eggert
2012-12-09 17:03     ` Eli Zaretskii [this message]
2012-12-10  1:08       ` Paul Eggert
2012-12-14 19:00         ` Paul Eggert
2012-12-09  8:32 ` Michael Albinus
2012-12-09  8:56   ` Paul Eggert
2012-12-09  9:32     ` Michael Albinus
2012-12-09 16:43 ` Wolfgang Jenkner
2012-12-10  0:46   ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d2yjcg53.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=13125@debbugs.gnu.org \
    --cc=cyd@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.