From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix browse-url not working when browse-url-browser-function is a list (regexp . function) pairs Date: Sat, 25 Apr 2015 20:33:38 +0300 Message-ID: <83d22sxgct.fsf@gnu.org> References: <878udhwgwo.fsf@gmail.com> <87h9s418yi.fsf@gmail.com> <83egn8xjcw.fsf@gnu.org> <87d22s16dl.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1429983258 27653 80.91.229.3 (25 Apr 2015 17:34:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Apr 2015 17:34:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: vibhavp@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 25 19:34:03 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ym3xp-0005oi-T5 for ged-emacs-devel@m.gmane.org; Sat, 25 Apr 2015 19:34:02 +0200 Original-Received: from localhost ([::1]:49002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym3xp-0003ZK-8y for ged-emacs-devel@m.gmane.org; Sat, 25 Apr 2015 13:34:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym3xm-0003Z4-9W for emacs-devel@gnu.org; Sat, 25 Apr 2015 13:33:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ym3xi-0006Hb-9m for emacs-devel@gnu.org; Sat, 25 Apr 2015 13:33:58 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:51148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym3xi-0006Fq-2D for emacs-devel@gnu.org; Sat, 25 Apr 2015 13:33:54 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NND00100HE9NT00@mtaout24.012.net.il> for emacs-devel@gnu.org; Sat, 25 Apr 2015 20:25:04 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NND00JTRHPS8070@mtaout24.012.net.il>; Sat, 25 Apr 2015 20:25:04 +0300 (IDT) In-reply-to: <87d22s16dl.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185881 Archived-At: > From: vibhavp@gmail.com > Date: Sat, 25 Apr 2015 22:40:14 +0530 > Cc: emacs-devel@gnu.org > > However (for some reason), (car bf) returns (browser-function) instead > of browse-function, which can be demonstrated with this piece of code: > > (defun abc () > (dolist (bf '(("i.imgur.com" browse-url-emacs) > ("youtube.com" browse-url-firefox) > ("." browse-url-chromium))) > (print (cdr bf)))) Shouldn't this be (defun abc () (dolist (bf '(("i.imgur.com" . browse-url-emacs) ("youtube.com" . browse-url-firefox) ("." . browse-url-chromium))) (print (cdr bf)))) instead? > The output of this is: > > (browse-url-emacs) > > (browse-url-firefox) > > (browse-url-chromium) > > nil > > This is not what we want, because applying (browse-url-emacs) to the URL > results in an "invalid function" error. Yes, because you used a list of lists instead of a list of conses, like the doc string of browse-url-browser-function requires. > If the "car" is replaced with a > "cadr", this is the output: > > "browse-url-emacs" > > "browse-url-youtube" > > "browse-url-chromium" > > nil > > This is the desired outcome. But it will fail with a list of cons cells.