From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master bc0b340: A better fix for bug#21739 Date: Sat, 24 Oct 2015 18:02:10 +0300 Message-ID: <83d1w4wbrh.fsf@gnu.org> References: <20151024070435.29886.62731@vcs.savannah.gnu.org> <83io5wwe9v.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1445698954 1245 80.91.229.3 (24 Oct 2015 15:02:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 Oct 2015 15:02:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: monnier@IRO.UMontreal.CA Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 24 17:02:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zq0Kt-0000VH-Pp for ged-emacs-devel@m.gmane.org; Sat, 24 Oct 2015 17:02:23 +0200 Original-Received: from localhost ([::1]:44624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq0Kt-0005gk-B7 for ged-emacs-devel@m.gmane.org; Sat, 24 Oct 2015 11:02:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq0Kf-0005gV-Kh for emacs-devel@gnu.org; Sat, 24 Oct 2015 11:02:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zq0Kc-0002t6-DE for emacs-devel@gnu.org; Sat, 24 Oct 2015 11:02:09 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:64401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq0Kc-0002sw-5K for emacs-devel@gnu.org; Sat, 24 Oct 2015 11:02:06 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NWQ00J00C2VED00@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sat, 24 Oct 2015 18:02:04 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWQ00JKNCFFC930@a-mtaout23.012.net.il>; Sat, 24 Oct 2015 18:02:03 +0300 (IDT) In-reply-to: <83io5wwe9v.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192547 Archived-At: > Date: Sat, 24 Oct 2015 17:07:56 +0300 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > > From: Stefan Monnier > > Cc: Eli Zaretskii > > Date: Sat, 24 Oct 2015 10:00:43 -0400 > > > > > * src/buffer.c (set_update_modelines_for_buf): New function. > > > (Fkill_buffer): Use it to set the global variable > > > update_mode_lines if the killed buffer was displayed in some > > > window. Don't set windows_or_buffers_changed. This is a better > > > fix for bug#21739 than the previous fix, since it will cause only > > > redisplay of mode lines, not of entire windows, but will still > > > catch attention of x_consider_frame_title in xdisp.c, which > > > redraws the frame title. > > > > Same question as before: why isn't this caught when the window->buffer > > is changed? > > Because changing a window's buffer only affects that single window. > How's that code to know the frame should be affected? I found a better way of fixing the original problem, see 7a6968b.