all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Marcin Borkowski <mbork@mbork.pl>
Cc: emacs-devel@gnu.org
Subject: Re: A problem with old bugs
Date: Wed, 08 Mar 2017 18:08:38 +0200	[thread overview]
Message-ID: <83d1drhhtl.fsf@gnu.org> (raw)
In-Reply-To: <874lz45k12.fsf@jane> (message from Marcin Borkowski on Wed, 08 Mar 2017 08:01:45 +0100)

> From: Marcin Borkowski <mbork@mbork.pl>
> Cc: emacs-devel@gnu.org
> Date: Wed, 08 Mar 2017 08:01:45 +0100
> 
> 
> > I replied to the 2 bug reports, let's hope we will get the ball
> > rolling again on them.
> 
> OK, I'll try to make a few final modifications and push them.

Thanks.

> > As for the patch posted here, I think it makes sense to make such
> > changes only if they are done in all modes.  Doing that only in one
> > major mode will only confuse people.  So if you'd like to pursue this
> > change (and I do think it would be a good change), please make the
> > change in a way that will produce similar behavior in all the other
> > modes with define their beginning-of-defun functionality.
> 
> I am not sure whether I understand.  The problem was specifically with
> lisp version of `beginning-of-defun'.  With other modes, there is a bit of
> a mess: some modes set `beginning-of-defun-function' (e.g. js-mode and
> js2-mode), some rebind C-M-a to their beginning-of-defun (e.g. c-mode).
> Now, other modes (again, I used c-mode and js2-mode for reference) do
> various things when arg=0 for beginning-of-defun - e.g. c-mode claims to
> go back to the current defun's header, js2-mode just pretends that arg
> is 1 etc.

I tried in Lisp and in C, and they both go up one line.

> Unifying that (1) might not be the best idea and (2) would require quite
> a lot of work for all Emacs built-in modes.

But if we do that only in Lisp, we just increase the mess, don't we?
I might be okay with fixing only a few popular modes, because that
will make the mess smaller, so it will be a step in the right
direction, even if we don't go all the way.

> I could try to do that, but this would take a bit.  Also, I do not know
> many of the languages involved, and I'd prefer not to touch their
> modes.

I don't expect you to need to know these languages, as
beginning-of-defun should already be well defined for them.



  reply	other threads:[~2017-03-08 16:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01  8:22 A problem with old bugs Marcin Borkowski
2017-03-01 10:26 ` Thien-Thi Nguyen
2017-03-01 13:28   ` Marcin Borkowski
2017-03-02  7:38     ` Thien-Thi Nguyen
2017-03-02 12:33       ` Noam Postavsky
2017-03-02 16:53         ` Richard Stallman
2017-03-07  6:17         ` Marcin Borkowski
2017-03-06 13:19     ` Phillip Lord
2017-03-07  6:16       ` Marcin Borkowski
2017-03-07 12:24         ` Phillip Lord
2017-03-01 16:16 ` Eli Zaretskii
2017-03-07  6:15   ` Marcin Borkowski
2017-03-07 16:51     ` Eli Zaretskii
2017-03-08  7:01       ` Marcin Borkowski
2017-03-08 16:08         ` Eli Zaretskii [this message]
2017-05-21 16:00 ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d1drhhtl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mbork@mbork.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.