From: Eli Zaretskii <eliz@gnu.org>
To: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
Cc: 26347-done@debbugs.gnu.org
Subject: bug#26347: patch for mwheel.el
Date: Wed, 12 Apr 2017 16:35:40 +0300 [thread overview]
Message-ID: <83d1chkatv.fsf@gnu.org> (raw)
In-Reply-To: <20170412.085638.30144618.tkk@misasa.okayama-u.ac.jp> (message from Tak Kunihiro on Wed, 12 Apr 2017 08:56:38 +0900 (JST))
> Date: Wed, 12 Apr 2017 08:56:38 +0900 (JST)
> Cc: 26347@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp
> From: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
>
> Please revise words and phrases as you wish.
Thanks, pushed, and I'm marking the bug done. See below for some
comments for your future contributions.
> On info revision, I also put a recipe to scroll less. Please
> discard the part if that should be done by different process.
Done. This is an unrelated change.
> # ChangeLog
>
> Support scrolling by tiling wheel
>
> Scroll right and left using wheel-right and wheel-left; This revision
> also makes use of touchpad and trackpad (Bug#26347).
This should be a single line no longer than 70 characters. Additional
lines can some after that, separated from the summary line by a blank
line.
> * doc/emacs/frames.texi (Mouse Commands): Document the change and recipe of scroll less
This should end in a period, and be at most 70 characters. Please use
"C-x 4 a" to format the message correctly.
> * lisp/mwheel.el (mwheel-scroll): Respond to wheel-right and wheel-left
> * lisp/mwheel.el (mwheel-tilt-scroll-p): Enable tilt scrolling
Log entries pertaining to the same source file should state the file
only once, like this:
* lisp/mwheel.el (mwheel-scroll): Respond to wheel-right and wheel-left.
(wheel-tilt-scroll-p): Enable tilt scrolling.
> # NEWS
>
> ** Emacs can scroll horizontally using mouse, touchpad, and trackbar.
> You can start scrolling by customizing `mwheel-tilt-scroll-p'. When
> direction of scroll is opposite, customize `mwheel-flip-direction'.
We use quoting 'like this' in NEWS.
> --- doc/emacs/frames.texi 2017-04-12 08:09:52.565691400 +0900
> +++ doc/emacs/frames-b.texi 2017-04-12 08:16:45.075204400 +0900
It is best to send patches by invoking "git diff" or "git format-patch".
> +Emacs also supports horizontal scrolling by tilting ``wheel''. The
There's no need to take ``wheel'' in quotes more than once, when it is
first mentioned. (It is quoted, because it's not a real wheel.) You
can see that the existing text only quotes it once.
> +variables @code{mwheel-tilt-scroll-p} turns the feature on. When
> +direction is opposite as you wish, turn the variable
> +@code{mwheel-flip-direction} on.
User variables should be indexed by using @vindex.
> +(defcustom mwheel-tilt-scroll-p nil
> + "Enable scroll using tilting mouse wheel."
> + :group 'mouse
> + :type 'boolean)
Defcustoms should have the :version tag stating the Emacs release
where they were first introduced, in this case 26.1.
I also made some of your defcustoms defvars, as I think there are too
many customizable variables in the patch.
Thanks again for working on this.
prev parent reply other threads:[~2017-04-12 13:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 11:11 bug#26347: patch for mwheel.el Tak Kunihiro
2017-04-03 15:00 ` Eli Zaretskii
2017-04-04 0:55 ` Tak Kunihiro
2017-04-04 2:52 ` Tak Kunihiro
2017-04-04 7:25 ` martin rudalics
2017-04-04 11:35 ` Tak Kunihiro
2017-04-04 14:34 ` Eli Zaretskii
2017-04-04 23:18 ` Tak Kunihiro
2017-04-05 2:36 ` Eli Zaretskii
2017-04-05 3:35 ` Tak Kunihiro
2017-04-11 9:47 ` Eli Zaretskii
2017-04-11 23:56 ` Tak Kunihiro
2017-04-12 13:35 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d1chkatv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26347-done@debbugs.gnu.org \
--cc=tkk@misasa.okayama-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.