From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25426: Copyright Assignment Completed Date: Sat, 06 May 2017 10:50:31 +0300 Message-ID: <83d1bmfmpk.fsf@gnu.org> References: <878tqgs7e1.fsf@andrewrobbins.info> <87o9v6673h.fsf@andrewrobbins.info> <83inlefo9h.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494057130 24517 195.159.176.226 (6 May 2017 07:52:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 May 2017 07:52:10 +0000 (UTC) Cc: 25426@debbugs.gnu.org To: contact@andrewrobbins.info Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 06 09:52:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6uVZ-0006Hi-PM for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 May 2017 09:52:05 +0200 Original-Received: from localhost ([::1]:50388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6uVf-0007cr-E4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 May 2017 03:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6uVa-0007Xj-6o for bug-gnu-emacs@gnu.org; Sat, 06 May 2017 03:52:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6uVX-0008M0-5M for bug-gnu-emacs@gnu.org; Sat, 06 May 2017 03:52:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d6uVX-0008Lw-24 for bug-gnu-emacs@gnu.org; Sat, 06 May 2017 03:52:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d6uVW-0006Br-Rn for bug-gnu-emacs@gnu.org; Sat, 06 May 2017 03:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2017 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25426-submit@debbugs.gnu.org id=B25426.149405706523733 (code B ref 25426); Sat, 06 May 2017 07:52:01 +0000 Original-Received: (at 25426) by debbugs.gnu.org; 6 May 2017 07:51:05 +0000 Original-Received: from localhost ([127.0.0.1]:57092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6uUb-0006Ai-2Q for submit@debbugs.gnu.org; Sat, 06 May 2017 03:51:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6uUa-0006AG-0c for 25426@debbugs.gnu.org; Sat, 06 May 2017 03:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6uUR-0008Fy-SL for 25426@debbugs.gnu.org; Sat, 06 May 2017 03:50:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6uUR-0008Fu-Oe; Sat, 06 May 2017 03:50:55 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1978 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d6uUR-0003DR-3N; Sat, 06 May 2017 03:50:55 -0400 In-reply-to: <83inlefo9h.fsf@gnu.org> (message from Eli Zaretskii on Sat, 06 May 2017 10:16:58 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132294 Archived-At: > Date: Sat, 06 May 2017 10:16:58 +0300 > From: Eli Zaretskii > Cc: 25426@debbugs.gnu.org > > Would people please look at the proposed patch and comment? I will > push to master in a few days if there are no comments. Some minor comments of my own: > 2017-01-12 Andrew Robbins > > * lisp/net/net-utils.el (ffap-string-at-point): Removed due to > 'net-utils-machine-at-point' obviating this autoloaded function. > (dig-program-options): New customization variable. > (nslookup-host, dns-lookup-host, run-dig): Can now specify optional > name server argument interactively (by prefix arg) & noninteractively. Please mention the bug number in the log message, for reference. > +(defcustom dig-program-options nil > + "Options for the dig program." > + :group 'net-utils > + :type '(repeat string)) When you introduce new defcustoms, please provide a :version tag whose value is the first Emacs version where this defcustom will be available (26.1 in this case). > +(defun nslookup-host (host &optional name-server) > + "Look up the DNS information for HOST (name or IP address). > +When called interactively, DNS resolver NAME-SERVER may be specified > +by passing the function a prefix argument." Our standard wording for such optional behavior is like this: Look up the DNS information for HOST (name or IP address). Optional argument NAME-SERVER says which server to use for DNS resolution. Interactively, prompt for NAME-SERVER if invoked with prefix argument. > +(defun dns-lookup-host (host &optional name-server) > + "Look up the DNS information for HOST (name or IP address). > +When called interactively, DNS resolver NAME-SERVER may be specified > +by passing the function a prefix argument." Same here. > +(defun run-dig (host &optional name-server) > + "Look up the DNS information for HOST (name or IP address). > +When called interactively, DNS resolver NAME-SERVER may be specified > +by passing the function a prefix argument." And here. Finally, please add a NEWS entry to describe these new features. Thanks for working on this.