From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: eww: call to eww-render looks incorrect Date: Sun, 03 Sep 2017 17:56:51 +0300 Message-ID: <83d177ygng.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1504450685 25663 195.159.176.226 (3 Sep 2017 14:58:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Sep 2017 14:58:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: raman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 03 16:57:51 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1doWLH-0005er-Dw for ged-emacs-devel@m.gmane.org; Sun, 03 Sep 2017 16:57:43 +0200 Original-Received: from localhost ([::1]:50614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doWLO-0000Fc-9u for ged-emacs-devel@m.gmane.org; Sun, 03 Sep 2017 10:57:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doWKd-0000EZ-1i for emacs-devel@gnu.org; Sun, 03 Sep 2017 10:57:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doWKY-0003jG-JY for emacs-devel@gnu.org; Sun, 03 Sep 2017 10:57:03 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doWKY-0003jB-Fz; Sun, 03 Sep 2017 10:56:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3450 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1doWKX-0000ub-Rt; Sun, 03 Sep 2017 10:56:58 -0400 In-reply-to: (message from raman on Sat, 02 Sep 2017 15:38:09 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217914 Archived-At: > Date: Sat, 02 Sep 2017 15:38:09 -0700 > From: raman > > In function eww: > > eww-render is the callback to url-retrieve: line 267 > (url-retrieve url 'eww-render > (list url nil (current-buffer)))) > The order of arguments in that list looks wrong --- at least per > the definition of eww-render, which is (status url buffer &rest args) In the current master eww-render's signature is (defun eww-render (status url &optional point buffer encode) So I think the CBARGS argument of url-retrieve in that case is correct, do you agree?