From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Suspicious warning in W64 build Date: Sat, 16 Sep 2017 11:52:56 +0300 Message-ID: <83d16rkot3.fsf@gnu.org> References: <1017454172.910810.1504618695244@mail.libero.it> <83tw0ezgi1.fsf@gnu.org> <1146932094.13821.1504798935795@mail.libero.it> <83mv66z66p.fsf@gnu.org> <102a4c21-c275-c73e-ec53-0d85975dc968@cs.ucla.edu> <83a825znuf.fsf@gnu.org> <831snhzkgw.fsf@gnu.org> <837ex9x7vf.fsf@gnu.org> <83tw0cwcle.fsf@gnu.org> <83h8wcw3td.fsf@gnu.org> <83377vx3d0.fsf@gnu.org> <83ingnq01t.fsf@gnu.org> <83fubrpxsv.fsf@gnu.org> <83r2v9masw.fsf@gnu.org> <83efr8mje5.fsf@gnu.org> <83o9qbkuxm.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505552012 17627 195.159.176.226 (16 Sep 2017 08:53:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Sep 2017 08:53:32 +0000 (UTC) Cc: fabrice.popineau@centralesupelec.fr, emacs-devel@gnu.org To: Richard Copley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 16 10:53:28 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt8qr-0004KY-Ra for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 10:53:25 +0200 Original-Received: from localhost ([::1]:56442 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt8qx-0008HL-Lq for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 04:53:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt8qN-0008HC-RJ for emacs-devel@gnu.org; Sat, 16 Sep 2017 04:52:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dt8qL-00083w-As for emacs-devel@gnu.org; Sat, 16 Sep 2017 04:52:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt8qL-00083q-6t; Sat, 16 Sep 2017 04:52:53 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4848 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dt8qG-0002c5-UB; Sat, 16 Sep 2017 04:52:51 -0400 In-reply-to: (message from Richard Copley on Sat, 16 Sep 2017 09:19:23 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218350 Archived-At: > From: Richard Copley > Date: Sat, 16 Sep 2017 09:19:23 +0100 > Cc: Fabrice Popineau , > Emacs Development > > > If you look at the beginning of w32.c, you will see that we include > > string.h before we #undef strerror. The header nt/inc/ms-w32.h > > #define's strerror to sys_strerror, so the inclusion of string.h > > should have supplied the prototype for sys_strerror. Why doesn't it > > do that in MinGW64? Does some system header #undef strerror too > > early? > > I see, thanks. No, there's no #undef. We end up including string.h before > ms-w32.h (w32.c includes io.h and io.h unconditionally includes string.h). Ah, okay. I added the prototype, so this problem should be gone now. Thanks.