all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: 29504@debbugs.gnu.org
Subject: bug#29504: 26.0.90; Can't enter Japanes text in a read-only buffer even if inhibit-read-only is t
Date: Sat, 09 Dec 2017 11:05:49 +0200	[thread overview]
Message-ID: <83d13ouv82.fsf@gnu.org> (raw)
In-Reply-To: <b4m7eu85s6l.fsf@jpl.org> (message from Katsumi Yamaoka on Thu, 30 Nov 2017 13:03:30 +0900)

> Date: Thu, 30 Nov 2017 13:03:30 +0900
> From: Katsumi Yamaoka <yamaoka@jpl.org>
> 
> On Thu, 30 Nov 2017 12:39:28 +0900, Katsumi Yamaoka wrote:
> > Not only Japanese, every input method should work in a read-only
> > buffer (such as that of eww) where the `inhibit-read-only' text
> > or overlay property is set in some areas.
> 
> A patch:
> 
> --- lisp/international/quail.el~	2017-11-26 22:09:06.936385900 +0000
> +++ lisp/international/quail.el	2017-11-30 04:01:39.868772300 +0000
> @@ -1332,3 +1332,5 @@
>  (defun quail-input-method (key)
> -  (if (or buffer-read-only
> +  (if (or (and buffer-read-only
> +	       (not (or inhibit-read-only
> +			(get-char-property (point) 'inhibit-read-only))))
>  	  (and overriding-terminal-local-map
> 

Looks OK to me.  Please push to the emacs-26 branch, and thanks.





  reply	other threads:[~2017-12-09  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  3:39 bug#29504: 26.0.90; Can't enter Japanes text in a read-only buffer even if inhibit-read-only is t Katsumi Yamaoka
2017-11-30  4:03 ` Katsumi Yamaoka
2017-12-09  9:05   ` Eli Zaretskii [this message]
2017-12-11  1:28     ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d13ouv82.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=29504@debbugs.gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.