From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 30186@debbugs.gnu.org, juri@linkov.net
Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd
Date: Sat, 27 Jan 2018 14:23:31 +0200 [thread overview]
Message-ID: <83d11vjxrw.fsf@gnu.org> (raw)
In-Reply-To: <20180127113713.GB4049@ACM> (message from Alan Mackenzie on Sat, 27 Jan 2018 11:37:13 +0000)
> Date: Sat, 27 Jan 2018 11:37:13 +0000
> Cc: juri@linkov.net, 30186@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > I'm not sure it would be possible to provide such a flag. Did you
> > look at the internals involved, and if so, can you tell where do we
> > know which kind of change caused the hooks to run?
>
> I envisage adding an extra boolean argument to prepare_to_modify_buffer,
> and to signal_after_change. When called from the text property
> routines, that argument would be true, otherwise it would be false.
What happens when both the text and the properties are changed?
> So, I'm changing my mind, after looking into it a bit more. Removing
> the with-silent-modifications from remove-yank-excluded-properties would
> not slow down undo in CC Mode buffers noticeably.
So let's do that now. I think the problem with read-passwd is a
security issue, so it should go to emacs-26, do you agree?
> It might slow down other modes which make extensive use of
> before/after-change-functions.
Let's see if any such modes show up.
> The extra flag for the change hooks might still be a good idea. It no
> longer seems pertinent for solving the current bug, though.
If it can be definitive, I might agree with you.
Alternatively, we could introduce a mechanism for interested modes to
prevent such changes from getting into buffer-undo-list.
next prev parent reply other threads:[~2018-01-27 12:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 21:29 bug#30186: 27.0.50; Password is not hidden in read-passwd Juri Linkov
2018-01-21 15:59 ` Eli Zaretskii
2018-01-21 21:19 ` Juri Linkov
2018-01-22 18:27 ` Glenn Morris
2018-01-22 18:45 ` Glenn Morris
2018-01-22 21:38 ` Juri Linkov
2018-01-23 21:38 ` Juri Linkov
2018-01-25 17:39 ` Alan Mackenzie
2018-01-25 21:15 ` Juri Linkov
2018-01-26 18:37 ` Alan Mackenzie
2018-01-26 19:08 ` Eli Zaretskii
2018-01-26 20:00 ` Alan Mackenzie
2018-01-27 9:40 ` Eli Zaretskii
2018-01-27 11:37 ` Alan Mackenzie
2018-01-27 12:23 ` Eli Zaretskii [this message]
2018-01-27 13:38 ` Alan Mackenzie
2018-01-27 21:43 ` Juri Linkov
2018-01-27 22:10 ` Alan Mackenzie
2018-01-27 8:27 ` martin rudalics
2018-01-27 9:21 ` Alan Mackenzie
2018-01-30 8:30 ` martin rudalics
2018-01-22 1:53 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d11vjxrw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30186@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.