bug#31092: 25.2: apropos-value: memory leak

bug#31092: 25.2: apropos-value: memory leak

[Boruch Baum]

In emacs version 25.2, in debian, I am reliably experiencing memory
exhaustion condition within five repeats of calls to function
`apropos-value'.

In the course of a cursory attempt to see what might be causing this, I
came across a curious global variable declaration `apropos-accumulator',
which doesn't look to be the culprit, but should be converted to a
locally scoped variable.

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

bug#31092: 25.2: apropos-value: memory leak

[Andreas Schwab]

On Apr 08 2018, Boruch Baum <boruch_baum@gmx.com> wrote:

> In the course of a cursory attempt to see what might be causing this, I
> came across a curious global variable declaration `apropos-accumulator',
> which doesn't look to be the culprit, but should be converted to a
> locally scoped variable.

That wouldn't change the amount of garbage produced, though.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#31092: 25.2: apropos-value: memory leak

[Boruch Baum]

On 2018-04-08 09:58, Andreas Schwab wrote:
> That wouldn't change the amount of garbage produced, though.

Didn't I say that myself?

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

bug#31092: 25.2: apropos-value: memory leak

[Noam Postavsky]

Boruch Baum <boruch_baum@gmx.com> writes:

> In emacs version 25.2, in debian, I am reliably experiencing memory
> exhaustion condition within five repeats of calls to function
> `apropos-value'.

I think this another manifestation of Bug#26952 "repeated buffer
insertion (e.g. yank-rectangle) consumes excessive memory (4GB+ for 90MB
of text)".

You can configure with REL_ALLOC=yes, or try Emacs 26.

bug#31092: 25.2: apropos-value: memory leak

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Sun, 08 Apr 2018 08:38:02 -0400
> Cc: 31092@debbugs.gnu.org
> 
> Boruch Baum <boruch_baum@gmx.com> writes:
> 
> > In emacs version 25.2, in debian, I am reliably experiencing memory
> > exhaustion condition within five repeats of calls to function
> > `apropos-value'.
> 
> I think this another manifestation of Bug#26952

Indeed, because I couldn't reproduce the problem on my system.

I suggest to try the latest pretest of Emacs 26.1 or build the
emacs-26 branch of the Emacs Git repository.

bug#31092: 25.2: apropos-value: memory leak

[Boruch Baum]

On 2018-04-08 08:38, Noam Postavsky wrote:
> You can configure with REL_ALLOC=yes, or try Emacs 26.

Call me coward (not lazy); I guess I'll wait for emacs26 to leave alpha
state a distant memory and be packaged for debian.

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

bug#31092: 25.2: apropos-value: memory leak

[Boruch Baum]

On 2018-04-08 15:59, Eli Zaretskii wrote:
> Indeed, because I couldn't reproduce the problem on my system.
>
> I suggest to try the latest pretest of Emacs 26.1 or build the
> emacs-26 branch of the Emacs Git repository.

Too much the coward for either option. BTW, at line 1154 of the file
apropos.el is a brief comment "permit gc", which might indicate that
this was a known issue at some point. The way that package uses variable
`apropos-accumulator' seems all wrong, creating it as a global and then
manually unsetting it; seems to me it should be locally scoped and
passed as an argument when necessary.

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

bug#31092: 25.2: apropos-value: memory leak

[Eli Zaretskii]

> Date: Sun, 8 Apr 2018 09:34:58 -0400
> From: Boruch Baum <boruch_baum@gmx.com>
> Cc: 31092@debbugs.gnu.org
> 
> On 2018-04-08 08:38, Noam Postavsky wrote:
> > You can configure with REL_ALLOC=yes, or try Emacs 26.
> 
> Call me coward (not lazy); I guess I'll wait for emacs26 to leave alpha
> state a distant memory and be packaged for debian.

Emacs 26 has left alpha state long ago, we expect RC1 in a day or two.
And I expect you to be able to find it packaged for Debian already.

bug#31092: 25.2: apropos-value: memory leak

[Boruch Baum]

On 2018-04-08 17:01, Eli Zaretskii wrote:
> Emacs 26 has left alpha state long ago, we expect RC1 in a day or two.

Hooray & congratulations!

> And I expect you to be able to find it packaged for Debian already.

I looked before I posted and didn't see it in the official debian
repositories. Looking a second time... Still don't see it. Not even in
the 'experimental' repository. Give them time. When it shows up in
'unstable' I'll notice. I'm looking forward to it!

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0