bug#31699: 26.1.50; find-face-definition defaults to non-face symbol

bug#31699: 26.1.50; find-face-definition defaults to non-face symbol

[Basil L. Contovounesios]

The following:

1. emacs -Q
2. M-: (insert "major-mode") RET
3. M-x find-face-definition RET RET

results in the following *Messages* line:

  find-function-search-for-symbol:
    Don’t know where ‘major-mode’ is defined

This is due to find-function-read using (variable-at-point t) instead of
(face-at-point t) to calculate the default completion candidate, even
when given an argument of 'defface.

Patch to follow.

Thanks,

-- 
Basil

In GNU Emacs 26.1.50 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-06-03 built on thunk
Repository revision: 16e8541b743a6beb1926fef53cf1bfaed9c346db
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description:	Debian GNU/Linux testing (buster)

bug#31699: 26.1.50; find-face-definition defaults to non-face symbol

[Basil L. Contovounesios]

[-- Attachment #1: Type: text/plain, Size: 87 bytes --]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Patch to follow.

As promised:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-default-candidate-of-find-face-definition.patch --]
[-- Type: text/x-diff, Size: 1027 bytes --]

From e129903ed87acedcadef203711b597a880ac36e0 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Sun, 3 Jun 2018 19:34:37 +0100
Subject: [PATCH] Fix default candidate of find-face-definition

* lisp/emacs-lisp/find-func.el (find-function-read): Use
face-at-point instead of variable-at-point for faces. (bug#31699)
---
 lisp/emacs-lisp/find-func.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
index ed8dc74506..13bbd9a7ec 100644
--- a/lisp/emacs-lisp/find-func.el
+++ b/lisp/emacs-lisp/find-func.el
@@ -464,6 +464,7 @@ find-function-read
 otherwise uses `variable-at-point'."
   (let* ((symb1 (cond ((null type) (function-called-at-point))
                       ((eq type 'defvar) (variable-at-point))
+                      ((eq type 'defface) (face-at-point t))
                       (t (variable-at-point t))))
          (symb  (unless (eq symb1 0) symb1))
          (predicate (cdr (assq type '((nil . fboundp)
-- 
2.17.1


[-- Attachment #3: Type: text/plain, Size: 20 bytes --]


Thanks,

-- 
Basil

bug#31699: 26.1.50; find-face-definition defaults to non-face symbol

[Eli Zaretskii]

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Sun, 03 Jun 2018 19:39:34 +0100
> 
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
> 
> > Patch to follow.
> 
> As promised:

Thanks, pushed to the master branch.