From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: pcase: Semantics of atom QPATS Date: Sat, 16 Jun 2018 09:57:57 +0300 Message-ID: <83d0wr1ami.fsf@gnu.org> References: <87tvqbjwyf.fsf@web.de> <87k1r3qro3.fsf@web.de> <87vaaj9y4b.fsf@web.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1529132208 11191 195.159.176.226 (16 Jun 2018 06:56:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 06:56:48 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 16 08:56:43 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fU58d-0002mg-HM for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 08:56:43 +0200 Original-Received: from localhost ([::1]:50468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU5Ak-0000YI-Kz for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 02:58:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU5A3-0000Y2-6I for emacs-devel@gnu.org; Sat, 16 Jun 2018 02:58:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fU5A0-0006NH-4D for emacs-devel@gnu.org; Sat, 16 Jun 2018 02:58:11 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU5A0-0006NC-0X; Sat, 16 Jun 2018 02:58:08 -0400 Original-Received: from [176.228.60.248] (port=2868 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fU59z-00089Z-8i; Sat, 16 Jun 2018 02:58:07 -0400 In-reply-to: <87vaaj9y4b.fsf@web.de> (message from Michael Heerdegen on Sat, 16 Jun 2018 06:03:16 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226348 Archived-At: > From: Michael Heerdegen > Date: Sat, 16 Jun 2018 06:03:16 +0200 > Cc: emacs-devel@gnu.org > > Stefan Monnier writes: > > > Sure. Feel free to add support for floats while you're there. > > Ok. Is this patch ok for emacs-26? Changes in documentation and comments are always okay there, but I'm uneasy with changes that modify behavior. Why is it important to support non-integer numbers in Emacs 26.2? > - ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat) > + ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat) Any reasons to use numberp and not number-or-marker-p?