From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame Date: Sun, 01 Jul 2018 21:05:07 +0300 Message-ID: <83d0w6ltm4.fsf@gnu.org> References: <87po2gkxpi.fsf@gmail.com> <87sh57yrax.fsf@gmail.com> <83lgawmwup.fsf@gnu.org> <878t6wxbzr.fsf@gmail.com> <5B38994B.2010605@gmx.at> <87va9zxfhe.fsf@gmail.com> <83in5zkjsk.fsf@gnu.org> <87tvpiyjz6.fsf@gmail.com> <83fu12lwh2.fsf@gnu.org> <87sh52yiwf.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1530468254 1579 195.159.176.226 (1 Jul 2018 18:04:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Jul 2018 18:04:14 +0000 (UTC) Cc: 31325@debbugs.gnu.org, monnier@iro.umontreal.ca To: John Shahid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 01 20:04:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZghi-0000EI-HY for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 20:04:06 +0200 Original-Received: from localhost ([::1]:55204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZgjp-0006eM-N2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2018 14:06:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZgje-0006dw-Qo for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 14:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZgjb-0002DV-L8 for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 14:06:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34465) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZgjb-0002Ch-Hu for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 14:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fZgjZ-00023J-Ol for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 14:06:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jul 2018 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31325-submit@debbugs.gnu.org id=B31325.15304683367853 (code B ref 31325); Sun, 01 Jul 2018 18:06:01 +0000 Original-Received: (at 31325) by debbugs.gnu.org; 1 Jul 2018 18:05:36 +0000 Original-Received: from localhost ([127.0.0.1]:42362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZgjA-00022b-9n for submit@debbugs.gnu.org; Sun, 01 Jul 2018 14:05:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZgj8-00022N-3X for 31325@debbugs.gnu.org; Sun, 01 Jul 2018 14:05:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZgj1-0000gY-O9 for 31325@debbugs.gnu.org; Sun, 01 Jul 2018 14:05:28 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZgiv-0000Mb-JK; Sun, 01 Jul 2018 14:05:21 -0400 Original-Received: from [176.228.60.248] (port=2530 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fZgiu-0003sY-No; Sun, 01 Jul 2018 14:05:21 -0400 In-reply-to: <87sh52yiwf.fsf@gmail.com> (message from John Shahid on Sun, 01 Jul 2018 17:18:08 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148060 Archived-At: > From: John Shahid > Cc: rudalics@gmx.at, 31325@debbugs.gnu.org, monnier@iro.umontreal.ca > Date: Sun, 01 Jul 2018 17:18:08 +0000 > > >> It just occurred to me that this change will break backward > >> comparability for those who bind some key to the `recenter' command, > >> since now the second argument will always be nil and thus won't > >> redisplay. Should we also change the interactive form of recenter to > >> use "p" for the second argument? That way the second arg is never nil > >> when used interactively. > > > > I think you are right. > > > > Alternatively, we could simply make 'recenter' behave specially in > > interactive invocations. But in any case, incompatible changes in > > behavior are bad, and should be avoided. > > I am happy to make the change. Should we just revert this patch and > instead of adding a new argument change the behavior of`recenter' to > redraw if called interactively ? > > How can we determine from C whether the function is called interactively > ? Is it ok to use `called-interactively-p' ? That'd be gross, I think. Going through the interactive spec, as you suggested originally, should be much simpler.