From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32108: 27.0.50; Insertion of char from input method during macro invocation duplicates the char Date: Sat, 21 Jul 2018 12:15:57 +0300 Message-ID: <83d0vhymnm.fsf@gnu.org> References: <83y3ejf4jb.fsf@gnu.org> <83lgaif7ds.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532164510 27676 195.159.176.226 (21 Jul 2018 09:15:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 21 Jul 2018 09:15:10 +0000 (UTC) Cc: monnier@iro.umontreal.ca, 32108@debbugs.gnu.org To: fgunbin@fastmail.fm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 21 11:15:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgnyi-00074B-Va for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Jul 2018 11:15:05 +0200 Original-Received: from localhost ([::1]:51245 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgo0o-0007dC-8f for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Jul 2018 05:17:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgo0i-0007d5-Gl for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2018 05:17:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgo0d-00088N-Fc for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2018 05:17:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fgo0d-00088I-Av for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2018 05:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fgo0d-0001gu-3R for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2018 05:17:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jul 2018 09:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32108 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 32108-submit@debbugs.gnu.org id=B32108.15321645706436 (code B ref 32108); Sat, 21 Jul 2018 09:17:01 +0000 Original-Received: (at 32108) by debbugs.gnu.org; 21 Jul 2018 09:16:10 +0000 Original-Received: from localhost ([127.0.0.1]:50207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgnzk-0001fi-Qm for submit@debbugs.gnu.org; Sat, 21 Jul 2018 05:16:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgnzj-0001fJ-A3 for 32108@debbugs.gnu.org; Sat, 21 Jul 2018 05:16:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgnzZ-0007p9-9q for 32108@debbugs.gnu.org; Sat, 21 Jul 2018 05:16:02 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgnzZ-0007os-57; Sat, 21 Jul 2018 05:15:57 -0400 Original-Received: from [176.228.60.248] (port=4351 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgnzX-0005Tx-TS; Sat, 21 Jul 2018 05:15:56 -0400 In-reply-to: <83lgaif7ds.fsf@gnu.org> (message from Eli Zaretskii on Wed, 11 Jul 2018 12:29:03 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148764 Archived-At: > Date: Wed, 11 Jul 2018 12:29:03 +0300 > From: Eli Zaretskii > Cc: fgunbin@fastmail.fm, 32108@debbugs.gnu.org > > > From: Glenn Morris > > Cc: Eli Zaretskii , 32108@debbugs.gnu.org > > Date: Tue, 10 Jul 2018 20:54:31 -0400 > > > > bisects to 30a6b1f81412044aa7dda5573b0142a0a03c4fd3. > > AFAICS, this happens because when an input method is active, read_char > is called recursively from quail-start-translation, and that recursive > call records the same character for the second time. > > Any ideas except introduction of a new variable, inhibit-record-char, > which quail-start-translation would bind to prevent recording of the > same key more than once? No other ideas, so I pushed to the master branch a fix along the above lines (except it turned out to be slightly more tricky due to input methods that translate sequences of two or more keys). Please test. Btw, it turned out the offending commit also caused us in this situation to output keys twice to the dribble file and insert them twice into recent-keys, so this fix resolves those problems as well. Let's see how much I broke this time...