* bug#32956: 26.1.50; t-m-m mark deactivation documentation
@ 2018-10-06 14:19 Charles A. Roelli
2018-10-06 16:39 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Charles A. Roelli @ 2018-10-06 14:19 UTC (permalink / raw)
To: 32956
t-m-m's documentation currently states:
The mark is "deactivated" by changing the buffer,
and after certain other operations that set the mark but whose
main purpose is something else--for example, incremental search,
M-<, and M->.
All of the examples (incremental search, M-<, and M->) do not always
deactivate the mark. For example, for incremental search, try from
emacs -Q:
M-< C-SPC C-s buffer RET > the mark is not deactivated
For M-< and M->, try:
M-< M-@ M-</M-> > neither M-< nor M-> deactivate the mark
There does seem to be at least one case where M-< and M-> do
deactivate the mark. Try:
double-clicking the word "buffer" in *scratch*
M-</M->
Both M-< and M-> deactivate the mark in this case. IIUC, this
behavior is explained in (info "(emacs) Shift Selection"):
A mark set via mouse commands behaves the same as a mark set via
shift-selection (*note Setting Mark::). For example, if you specify a
region by dragging the mouse, you can continue to extend the region
using shifted cursor motion commands. In either case, any unshifted
cursor motion command deactivates the mark.
In light of this, here's a change for review on emacs-26:
diff --git a/lisp/simple.el b/lisp/simple.el
index d5674aa..8bbafe4 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -5793,10 +5793,10 @@ transient-mark-mode
Transient Mark mode is a global minor mode. When enabled, the
region is highlighted with the `region' face whenever the mark
-is active. The mark is \"deactivated\" by changing the buffer,
-and after certain other operations that set the mark but whose
-main purpose is something else--for example, incremental search,
-\\[beginning-of-buffer], and \\[end-of-buffer].
+is active. The mark is \"deactivated\" after certain non-motion
+commands, including those that change the text in the buffer, and
+during shift or mouse selection by any unshifted cursor motion
+command (see Info node `Shift Selection' for more details).
You can also deactivate the mark by typing \\[keyboard-quit] or
\\[keyboard-escape-quit].
^ permalink raw reply related [flat|nested] 10+ messages in thread
* bug#32956: 26.1.50; t-m-m mark deactivation documentation
2018-10-06 14:19 bug#32956: 26.1.50; t-m-m mark deactivation documentation Charles A. Roelli
@ 2018-10-06 16:39 ` Eli Zaretskii
2018-10-06 19:29 ` Charles A. Roelli
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2018-10-06 16:39 UTC (permalink / raw)
To: charles; +Cc: 32956
> Date: Sat, 06 Oct 2018 16:19:55 +0200
> From: charles@aurox.ch (Charles A. Roelli)
>
> In light of this, here's a change for review on emacs-26:
>
> diff --git a/lisp/simple.el b/lisp/simple.el
> index d5674aa..8bbafe4 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -5793,10 +5793,10 @@ transient-mark-mode
>
> Transient Mark mode is a global minor mode. When enabled, the
> region is highlighted with the `region' face whenever the mark
> -is active. The mark is \"deactivated\" by changing the buffer,
> -and after certain other operations that set the mark but whose
> -main purpose is something else--for example, incremental search,
> -\\[beginning-of-buffer], and \\[end-of-buffer].
> +is active. The mark is \"deactivated\" after certain non-motion
> +commands, including those that change the text in the buffer, and
> +during shift or mouse selection by any unshifted cursor motion
> +command (see Info node `Shift Selection' for more details).
>
> You can also deactivate the mark by typing \\[keyboard-quit] or
> \\[keyboard-escape-quit].
Fine with me (but do please make similar changes in the ELisp manual).
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#32956: 26.1.50; t-m-m mark deactivation documentation
2018-10-06 16:39 ` Eli Zaretskii
@ 2018-10-06 19:29 ` Charles A. Roelli
0 siblings, 0 replies; 10+ messages in thread
From: Charles A. Roelli @ 2018-10-06 19:29 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 32956
tags 32956 fixed
close 32956 26.2
quit
> Date: Sat, 06 Oct 2018 19:39:57 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Fine with me (but do please make similar changes in the ELisp manual).
Ok, I've pushed the fix. The manual does not have the same error, so
I've left it as is.
^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <<m2in2f17jo.fsf@aurox.ch>]
* bug#32956: 26.1.50; t-m-m mark deactivation documentation
[not found] <<m2in2f17jo.fsf@aurox.ch>
@ 2018-10-06 14:48 ` Drew Adams
2018-10-06 19:44 ` Charles A. Roelli
0 siblings, 1 reply; 10+ messages in thread
From: Drew Adams @ 2018-10-06 14:48 UTC (permalink / raw)
To: charles, 32956
> Transient Mark mode is a global minor mode. When enabled, the
> region is highlighted with the `region' face whenever the mark
> -is active. The mark is \"deactivated\" by changing the buffer,
> -and after certain other operations that set the mark but whose
> -main purpose is something else--for example, incremental search,
> -\\[beginning-of-buffer], and \\[end-of-buffer].
> +is active. The mark is \"deactivated\" after certain non-motion
> +commands, including those that change the text in the buffer, and
> +during shift or mouse selection by any unshifted cursor motion
> +command (see Info node `Shift Selection' for more details).
>
> You can also deactivate the mark by typing \\[keyboard-quit] or
> \\[keyboard-escape-quit].
The Elisp manual, node `The Mark' has similar text, so if
an update to the doc string is called for then maybe the
manual text needs a similar update.
____
BTW, this (the manual) might be a good place to mention
to Elisp users that (in `transient-mark-mode', at least) the
mark is also deactivated by default after each command,
by the command loop. Some commands inhibit this
automatic deactivation.
This is a fairly common question by Elisp users who try to
write a command that they think/hope will end with the
region staying activated (e.g. for use by a follow-up command).
This is maybe a good place to tell them about the automatic
deactivation (by default), and maybe even let them know
that they can use (setq deactivate-mark nil) at the end of a
command definition to inhibit automatic deactivation.
In fact, this bit of `The Mark' doesn't seem quite right:
A command can ... request deactivation of the mark upon
return to the editor command loop by setting the variable
'deactivate-mark' to a non-'nil' value.
I think that's a bit backward, at least in `transient-mark-mode'.
IIUC, the command loop automatically deactivates the mark
after each command, unless `deactivate-mark' is non-nil.
A command (in t-m-m, at least) need not set that variable to
non-nil to deactivate the mark, as it is normally treated as such.
The opposite is true: If you want the region to stay active
after your command is done (so that it is active for the
next command) then your command can set `deactivate-mark'
to nil to prevent automatic deactivation.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#32956: 26.1.50; t-m-m mark deactivation documentation
2018-10-06 14:48 ` Drew Adams
@ 2018-10-06 19:44 ` Charles A. Roelli
0 siblings, 0 replies; 10+ messages in thread
From: Charles A. Roelli @ 2018-10-06 19:44 UTC (permalink / raw)
To: Drew Adams; +Cc: 32956
> Date: Sat, 6 Oct 2018 14:48:01 +0000 (UTC)
> From: Drew Adams <drew.adams@oracle.com>
> Content-Type: text/plain; charset=us-ascii
>
> The Elisp manual, node `The Mark' has similar text, so if
> an update to the doc string is called for then maybe the
> manual text needs a similar update.
The manual looks correct to me. I think in this case the manual has
been updated without an equivalent change to the docstring of t-m-m.
> BTW, this (the manual) might be a good place to mention
> to Elisp users that (in `transient-mark-mode', at least) the
> mark is also deactivated by default after each command,
> by the command loop. Some commands inhibit this
> automatic deactivation.
>
> This is a fairly common question by Elisp users who try to
> write a command that they think/hope will end with the
> region staying activated (e.g. for use by a follow-up command).
>
> This is maybe a good place to tell them about the automatic
> deactivation (by default), and maybe even let them know
> that they can use (setq deactivate-mark nil) at the end of a
> command definition to inhibit automatic deactivation.
Hmm, deactivate-mark is nil by default -- what effect would setting it
to "nil" again have? Is it to counteract the effect of previous
function calls within the command, which may have set
"deactivate-mark" to "t"?
> In fact, this bit of `The Mark' doesn't seem quite right:
>
> A command can ... request deactivation of the mark upon
> return to the editor command loop by setting the variable
> 'deactivate-mark' to a non-'nil' value.
>
> I think that's a bit backward, at least in `transient-mark-mode'.
> IIUC, the command loop automatically deactivates the mark
> after each command, unless `deactivate-mark' is non-nil.
Again, though, deactivate-mark is "nil" by default, so it seems that
some editing function has to set it to "t" for the mark to really be
deactivated.
^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <<<m2in2f17jo.fsf@aurox.ch>]
end of thread, other threads:[~2018-10-08 17:23 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-06 14:19 bug#32956: 26.1.50; t-m-m mark deactivation documentation Charles A. Roelli
2018-10-06 16:39 ` Eli Zaretskii
2018-10-06 19:29 ` Charles A. Roelli
[not found] <<m2in2f17jo.fsf@aurox.ch>
2018-10-06 14:48 ` Drew Adams
2018-10-06 19:44 ` Charles A. Roelli
[not found] <<<m2in2f17jo.fsf@aurox.ch>
[not found] ` <<5399d374-2089-492a-b830-9eb2baac82a6@default>
[not found] ` <<m2efd2272p.fsf@aurox.ch>
2018-10-07 1:02 ` Drew Adams
2018-10-07 14:39 ` Charles A. Roelli
2018-10-07 19:42 ` Charles A. Roelli
2018-10-08 2:28 ` Eli Zaretskii
2018-10-08 17:23 ` Charles A. Roelli
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.