From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Fri, 08 Feb 2019 23:29:38 +0200 Message-ID: <83d0o2otod.fsf@gnu.org> References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <837eg8dpd6.fsf@gnu.org> <83zhr6pqmr.fsf@gnu.org> <83womapgll.fsf@gnu.org> <83lg2qp8eq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122006"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 22:31:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsDkY-000VdE-4S for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 22:31:54 +0100 Original-Received: from localhost ([127.0.0.1]:35507 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsDkX-0002zm-4Y for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 16:31:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsDif-0001q7-Vk for emacs-devel@gnu.org; Fri, 08 Feb 2019 16:30:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsDif-00088F-Sz; Fri, 08 Feb 2019 16:29:57 -0500 Original-Received: from [176.228.60.248] (port=2966 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gsDif-0007Q7-G4; Fri, 08 Feb 2019 16:29:57 -0500 In-reply-to: (message from Robert Pluim on Fri, 08 Feb 2019 17:41:02 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233144 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Fri, 08 Feb 2019 17:41:02 +0100 > > > #ifdef HAVE_FREETYPE > > #ifdef HAVE_XFT > > register_font_driver (&xftfont_driver, f); > > #else /* not HAVE_XFT */ > > register_font_driver (&ftxfont_driver, f); > > #endif /* not HAVE_XFT */ > > #endif /* HAVE_FREETYPE */ > > register_font_driver (&xfont_driver, f); > > #endif /* not USE_CAIRO */ > > > > Here, xftfont and ftxfont are clearly 2 more-or-less equivalent > > alternatives, and bot rely on Freetype. So I don't understand why not > > having XFT is taken by configure.ac to mean there's no Freetype, > > either. Sounds like a mistake, or did I miss something? > > Interesting. Glenn made that change in > 46dcfee46cb241a0f8e34da679ca8b42e8ee8d46 , but thatʼs quite a while > ago. > > Like I said, we can change stuff around here, but I think the easiest > thing to do is just get rid of it. Is XFT sufficiently widespread these days that we can rely on it being available on most systems? If so, I guess it's okay to drop ftxfont.c.