From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34621: [PATCH] Fix rgrep in dired taking default search file pattern from directory name (e.g. *.11 for django-1.11) Date: Tue, 09 Apr 2019 17:18:54 +0300 Message-ID: <83d0lv6z3l.fsf@gnu.org> References: <08e7108149ce2374fd0c9b7fc3e6ae38@reckondigital.com> <40839b67-bce7-4a01-89f1-c14643b18b32@default> <80f4335be923e21fe782780c6812a03f@reckondigital.com> <878sxd248k.fsf@mail.linkov.net> <82347809b60dfc4e18a822d2d604475c@reckondigital.com> <87mul0wacr.fsf@mail.linkov.net> <336a681ce53ad7623fc5f98936577d82@reckondigital.com> <8736mrcs5j.fsf@gmail.com> <873a32455e7fd2288e3280ecaebc5f00@reckondigital.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="143261"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34621@debbugs.gnu.org, npostavs@gmail.com To: Christopher Thorne Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 09 16:20:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDrbg-000b8s-B1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 16:20:12 +0200 Original-Received: from localhost ([127.0.0.1]:42423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDrbf-0008Uj-CB for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 10:20:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDrbX-0008TO-CL for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 10:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDrbW-0003Lr-Gi for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 10:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDrbW-0003Li-8t for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 10:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDrbW-0002sD-1o for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 10:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2019 14:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34621 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34621-submit@debbugs.gnu.org id=B34621.155481954610952 (code B ref 34621); Tue, 09 Apr 2019 14:20:01 +0000 Original-Received: (at 34621) by debbugs.gnu.org; 9 Apr 2019 14:19:06 +0000 Original-Received: from localhost ([127.0.0.1]:51816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDrab-0002qa-KW for submit@debbugs.gnu.org; Tue, 09 Apr 2019 10:19:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDraZ-0002q5-O3 for 34621@debbugs.gnu.org; Tue, 09 Apr 2019 10:19:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDraT-00030g-NO; Tue, 09 Apr 2019 10:18:57 -0400 Original-Received: from [176.228.60.248] (port=3333 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hDraT-0005u6-0N; Tue, 09 Apr 2019 10:18:57 -0400 In-reply-to: <873a32455e7fd2288e3280ecaebc5f00@reckondigital.com> (message from Christopher Thorne on Tue, 09 Apr 2019 13:23:11 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157416 Archived-At: > Date: Tue, 09 Apr 2019 13:23:11 +0100 > From: Christopher Thorne > Cc: Noam Postavsky > > > Just a minor suggestion meta suggestion: post your patches by attaching > > the output from 'git format-patch', rather than inlining the output of > > git diff. That will avoid patch corruption due to line-wrapping, like > > in the above quote (although that line is also a bit long, and you > > should break it manually). > > Thanks, Noam. Trying this now. Patch should be attached. One more nit to a well-formatted patch: > * lisp/progmodes/grep.el (grep-read-files): Allow major modes to > define file name to use for default search pattern > * lisp/dired.el (dired-grep-file-name-for-default-pattern): Use file > at point for grep file name pattern Please end each sentence with a period. Also, it is better to have the bug number as part of the detailed descriptions, not as part of the header line (in Subject), because that leaves you more space for the header. Thanks.