From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Date: Mon, 24 Jun 2019 20:23:22 +0300 Message-ID: <83d0j2nbhx.fsf@gnu.org> References: <183863e3-f4e3-4e31-a557-62ac98ce77aa@email.android.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="54851"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org To: dancol@dancol.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 19:23:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfShB-000EAx-9e for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 19:23:57 +0200 Original-Received: from localhost ([::1]:53358 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfShA-0003aK-76 for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 13:23:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44613) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfSgf-0003VS-Cv for emacs-devel@gnu.org; Mon, 24 Jun 2019 13:23:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hfSgf-0003YM-2u; Mon, 24 Jun 2019 13:23:25 -0400 Original-Received: from [176.228.60.248] (port=2152 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hfSge-0004eD-56; Mon, 24 Jun 2019 13:23:24 -0400 In-reply-to: <183863e3-f4e3-4e31-a557-62ac98ce77aa@email.android.com> (dancol@dancol.org) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238109 Archived-At: > Date: Mon, 24 Jun 2019 09:06:37 -0700 > From: dancol@dancol.org > Cc: Andy Moreton , emacs-devel@gnu.org > > > Building commit 65d45def8d71e50d111adf1141011a5d30a27447 still fails on > > MSYS2 (Windows), and adds warnings: > > I'm working on this. > > Thanks. I thought gnulib was supposed to "just work" here. It mostly does, but not in this case, evidently. And even if it did, we cannot use in Emacs Gnulib modules that manipulate file names, because Gnulib on Windows supports only file names encodable in the current ANSI codepage, whereas Emacs supports the full Unicode. Also, in this case there are two more problems: (1) canonicalize-lgpl.c doesn't support symlinks on Windows, and (2) it uses 'stat', which we replaced in Emacs by our own enhanced implementation. So there are more than enough reasons for this changeset to require additional work on Windows ;-) Thanks for fixing this issue on Posix platforms. Did you close the bug which Richard opened about this?