From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36369: Master doesn't use its pdump Date: Sat, 29 Jun 2019 10:14:28 +0300 Message-ID: <83d0iwhnhn.fsf@gnu.org> References: <5311D227-3E56-45FC-9F91-BF217D4A4256@gnu.org> <834l4cl8k7.fsf@gnu.org> <835zorjhoo.fsf@gnu.org> <83ef3ei4q9.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="239522"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36369@debbugs.gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 29 09:15:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hh7Zn-0010Co-Pl for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 09:15:11 +0200 Original-Received: from localhost ([::1]:38104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hh7Zm-0007UF-5x for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 03:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40663) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hh7Zg-0007U5-QB for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:15:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hh7Zf-0000oy-Lu for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hh7Zf-0000of-IU for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hh7Ze-0002nd-B7 for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2019 07:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36369 X-GNU-PR-Package: emacs Original-Received: via spool by 36369-submit@debbugs.gnu.org id=B36369.156179249110727 (code B ref 36369); Sat, 29 Jun 2019 07:15:02 +0000 Original-Received: (at 36369) by debbugs.gnu.org; 29 Jun 2019 07:14:51 +0000 Original-Received: from localhost ([127.0.0.1]:43336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hh7ZT-0002mx-0E for submit@debbugs.gnu.org; Sat, 29 Jun 2019 03:14:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hh7ZS-0002mk-Ay for 36369@debbugs.gnu.org; Sat, 29 Jun 2019 03:14:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hh7ZN-0000ZT-7f for 36369@debbugs.gnu.org; Sat, 29 Jun 2019 03:14:45 -0400 Original-Received: from [176.228.60.248] (port=2249 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hh7ZG-0004RD-1Z; Sat, 29 Jun 2019 03:14:38 -0400 In-reply-to: (message from Richard Stallman on Fri, 28 Jun 2019 23:18:46 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161796 Archived-At: > From: Richard Stallman > Cc: 36369@debbugs.gnu.org > Date: Fri, 28 Jun 2019 23:18:46 -0400 > > > I think I understand why it doesn't complete the build for you: it's > > because you say "make -k emacs" instead of just "make -k". > > I think that is a bug. > > Makefile seems not to have a separate rule for the file > 'emacs.pdump'. It treats that as an aspect of 'emacs'. Thus, the > 'emacs' rule should write 'emacs.pdmp' correctly too. I think this is problematic because we still support the unexec build as well. That build doesn't produce emacs.pdmp at all. > I tried 'make -k' just now. It did write 'emacs.pdmp'. > > Then I deleted 'alloc.o' and then 'make -k'. > It loaded up and dumped, writing 'boostrap-emacs.pdmp'. > Then it loaded up and dumped again, writing 'emacs.pdmp'. > > That was not necessary. Once should have been enough. It's enough when all the Lisp files are already byte-compiled. When some of them aren't, the two dumps are not identical, as the first one loads the uncompiled Lisp files, the second one loads the compiled ones. And there are other potential changes, as the first dump runs temacs with --temacs=pbootstrap switch, the second with --temacs=pdump. See loadup.el for how these are different. > Can't you > > omit the "emacs" part? If not, why not? > > The reason I omit it is that this was, in the past, a way to avoid > rebuilding stuff I didn't need to rebuild. Perhaps it was to avoid > recompiling Lisp files (which takes a long time so I always chose > manually what to recompile). I don't remewmber for sure. If you don't want to compile Lisp files automatically, I think saying "make -k emacs.pdmp" should be your new paradigm. > But it still seems like an error that the 'emacs' target does not > deliver a working 'emacs'. If we can tweak src/Makefile.in to do that, while not losing the ability to support unexec, it would be a good change, I agree.