From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17052: substitute-command-keys strips text properties Date: Sun, 18 Aug 2019 20:19:26 +0300 Message-ID: <83d0h2mlwh.fsf@gnu.org> References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="35084"; mail-complaints-to="usenet@blaine.gmane.org" Cc: lekktu@gmail.com, larsi@gnus.org, 8951@debbugs.gnu.org, 17052@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 18 19:20:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzOqk-0008zo-Ng for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 19:20:14 +0200 Original-Received: from localhost ([::1]:42212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzOqi-0004Fx-AB for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 13:20:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43074) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzOqZ-0004Eb-CB for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzOqY-0000wV-FS for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzOqY-0000wK-C9 for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzOqY-0001V5-6W for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2019 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17052 X-GNU-PR-Package: emacs Original-Received: via spool by 17052-submit@debbugs.gnu.org id=B17052.15661487765709 (code B ref 17052); Sun, 18 Aug 2019 17:20:02 +0000 Original-Received: (at 17052) by debbugs.gnu.org; 18 Aug 2019 17:19:36 +0000 Original-Received: from localhost ([127.0.0.1]:58491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOq8-0001Tx-Gs for submit@debbugs.gnu.org; Sun, 18 Aug 2019 13:19:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOq5-0001Te-LI; Sun, 18 Aug 2019 13:19:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzOq0-0000dH-3H; Sun, 18 Aug 2019 13:19:28 -0400 Original-Received: from [176.228.60.248] (port=2509 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hzOpz-0008S2-J8; Sun, 18 Aug 2019 13:19:27 -0400 In-reply-to: (message from Stefan Kangas on Sun, 18 Aug 2019 19:08:18 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165342 Archived-At: > From: Stefan Kangas > Date: Sun, 18 Aug 2019 19:08:18 +0200 > Cc: Eli Zaretskii , 17052@debbugs.gnu.org, lekktu@gmail.com, > 8951@debbugs.gnu.org > > > I had a look at that function now and, er, no. :-) Perhaps it should > > be rewritten in Emacs Lisp? Then it'd be pretty trivial to fix this > > stuff. > > The Fsubstitute_command_keys function is indeed a bit hairy, and I > agree that a conversion to Lisp is the most reasonable next step. > > I've actually been working a patch to convert it to Lisp for Bug#8951, > but it's not finished yet. The difficulty is that it has a couple of > helper functions that also needs to be lifted, which makes the job > bigger than just the function Fsubstitute_command_keys. > > My goal is to get the Lisp version to produce the same output as the C > version, which currently seems to be a feasible goal. Once it's in > Lisp it should be easier to make further improvements, fix bugs, etc. Maybe we should first talk a bit about why Lars you think it would be "pretty trivial" to keep properties in Lisp, but not in C. I'm probably missing something very basic here, because I don't see why it would be easier in Lisp.