From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38457: 27.0.50; dabbrev-expand regression due to message change Date: Fri, 13 Dec 2019 10:57:59 +0200 Message-ID: <83d0cs8uw8.fsf@gnu.org> References: <8736e3vve8.fsf@gmx.net> <8736e2coyv.fsf@mail.linkov.net> <83y2vujd0y.fsf@gnu.org> <87blspm0sm.fsf@mail.linkov.net> <837e3ckbem.fsf@gnu.org> <871rtjn0kt.fsf@mail.linkov.net> <83lfrrigj8.fsf@gnu.org> <87eexiqps5.fsf@mail.linkov.net> <83lfrphp94.fsf@gnu.org> <87wob7g2jk.fsf@mail.linkov.net> <83k177ebs0.fsf@gnu.org> <87muc27prn.fsf@mail.linkov.net> <83tv6acgq5.fsf@gnu.org> <87eexdoygh.fsf@mail.linkov.net> <83tv68c0nb.fsf@gnu.org> <87d0cubfxx.fsf@mail.linkov.net> <83a77y9k35.fsf@gnu.org> <87eex9jf14.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="144623"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38457@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 13 09:59:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifgn0-000bW7-Hl for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 09:59:10 +0100 Original-Received: from localhost ([::1]:42848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifgmz-0001Ao-Ej for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 03:59:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57647) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifgmt-0001Ae-R8 for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 03:59:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifgms-000415-LM for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 03:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55253) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifgms-00040c-Fv for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 03:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ifgms-0004jM-EV for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 03:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2019 08:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38457 X-GNU-PR-Package: emacs Original-Received: via spool by 38457-submit@debbugs.gnu.org id=B38457.157622749117963 (code B ref 38457); Fri, 13 Dec 2019 08:59:02 +0000 Original-Received: (at 38457) by debbugs.gnu.org; 13 Dec 2019 08:58:11 +0000 Original-Received: from localhost ([127.0.0.1]:32993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifgm3-0004fd-JP for submit@debbugs.gnu.org; Fri, 13 Dec 2019 03:58:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifgm2-0004fK-GW for 38457@debbugs.gnu.org; Fri, 13 Dec 2019 03:58:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ifglw-0002sU-VX; Fri, 13 Dec 2019 03:58:05 -0500 Original-Received: from [176.228.60.248] (port=3354 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ifglv-0007m2-KN; Fri, 13 Dec 2019 03:58:04 -0500 In-reply-to: <87eex9jf14.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 13 Dec 2019 01:12:50 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173254 Archived-At: > From: Juri Linkov > Cc: 38457@debbugs.gnu.org > Date: Fri, 13 Dec 2019 01:12:50 +0200 > > >> If you want to set message-in-echo-area to t in the release branch, > >> that's fine. > > > > That would mean bring back all the problems for which these changes > > were made. So it would be the worst of all worlds, and thus makes > > very little sense to me. > > Then your proposed implementation should be activated when > minibuffer-message-timeout is set to a non-nil value. > Otherwise, when it's a number, it should use the timer. That leaves open the issue of the default value of minibuffer-message-timeout. I don't think we can change it, because it affects minibuffer-message as well. But we could have a new option, which would affect only the duplicate function you mention below. If the new option by default makes the message stay until the next one or until user input, I think this would be an okay solution that satisfies everyone, at least for Emacs 27. > > And in any case, minibuffer-message already behaves differently: it > > logs the message in *Messages*, something it never did and is not > > documented, and you suggested another change, to make it start the > > debugger per debug-on-message. These change behavior of any direct > > callers of minibuffer-message in incompatible ways, something I don't > > think we have a good reason to do. > > I see no reason not to change minibuffer-message. But if you think > it should never change, let's create a duplicate function > message-in-minibuffer. Fine with me, as long as the duplicate is an internal function. Maybe that new internal function should be invoked from message3_nolog instead, btw? That would remove the need to duplicate the functionality of message_dolog. Assuming you agree, once this change is made, some of the recent changes related to these issues should be reverted. Can I ask you to review those related changesets and publish a list of those which need to be reverted or augmented? Thanks.