From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-27 60c84ad: ; * etc/TODO: Fix last change. Date: Tue, 03 Mar 2020 18:06:06 +0200 Message-ID: <83d09txw29.fsf@gnu.org> References: <20200229173124.11831.98476@vcs0.savannah.gnu.org> <20200229173125.E2D3A21167@vcs0.savannah.gnu.org> <83zhczxa2t.fsf@gnu.org> <83eeuay0ch.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="32105"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 03 17:07:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9A4c-0007nU-Ae for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Mar 2020 17:07:10 +0100 Original-Received: from localhost ([::1]:49488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9A4I-0006wB-1s for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Mar 2020 11:06:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51935) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9A3n-0006VM-0i for emacs-devel@gnu.org; Tue, 03 Mar 2020 11:06:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j9A3m-0006Vu-LD; Tue, 03 Mar 2020 11:06:18 -0500 Original-Received: from [176.228.60.248] (port=2973 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j9A3e-00076X-NO; Tue, 03 Mar 2020 11:06:18 -0500 In-Reply-To: (message from Robert Pluim on Tue, 03 Mar 2020 13:51:14 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245188 Archived-At: > From: Robert Pluim > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Tue, 03 Mar 2020 13:51:14 +0100 > > >>>>> On Mon, 02 Mar 2020 21:55:32 +0100, Robert Pluim said: > Robert> One thing we could do with emoji-data.txt is extract which codepoints > Robert> are emoji and use that to set up the fontsets appropriately. > > That looks easy enough. Of course the fontsets end up not being used > for certain codepoints because of use-default-font-for-symbols > defaulting to t. > > What should be done here? Create another char table analagous to > char-script-table, add all the emojis from emoji-data.txt to it, and > check whether the char is in that table in fontset.c:face_for_char? I think it would be simpler and cleaner to define a new script, 'emoji', and update admin/unidata/blocks.awk to produce it for the relevant blocks (including Variation Selectors, btw). Then no change is needed in face_for_char, since that is only in effect for the 'symbol' script. As a nice bonus, this will also allow a much easier customization of the fontsets, so that fonts for symbols can be different from fonts for emoji. There's an issue with the codepoints in the U+2XXX and U+3XXX blocks: some of them can have Emoji glyph variations, but putting them into the 'emoji' script is probably not a good idea, as long as Emacs selects a font based on a single character. I guess we will have to leave them in 'symbol' for now. The file admin/notes/unicode tells what has to be done when a new script is added to Emacs.