From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18336: 24.4.50; When editing externally changed file, Emacs asks too many questions Date: Sun, 22 Mar 2020 19:09:39 +0200 Message-ID: <83d094co4s.fsf@gnu.org> References: <87mwaq74xg.fsf@fencepost.gnu.org> <87h7z86hs9.fsf@stefankangas.se> <86v9nooxcg.fsf@gmail.com> <87tv38kp33.fsf@fencepost.gnu.org> <83sgisypbd.fsf@gnu.org> <87pndwklz6.fsf@fencepost.gnu.org> <83o8tgyn1k.fsf@gnu.org> <874kv83pg7.fsf@fencepost.gnu.org> <83lfokylpp.fsf@gnu.org> <87r1yb8kbv.fsf@gmail.com> <87wo8340ct.fsf@stefankangas.se> <874kv7ozf9.fsf@fencepost.gnu.org> <87o8tf7xu3.fsf@gmail.com> <83mu8yyawu.fsf@gnu.org> <874kv299f7.fsf@gmail.com> <87pndqet7k.fsf@fencepost.gnu.org> <8536amk7q6.fsf@gmail.com> <838skevbsn.fsf@gnu.org> <87y2rtjinc.fsf@gmail.com> <83k13ccvah.fsf@gnu.org> <87r1xkjsvf.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123178"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dak@gnu.org, stefan@marxist.se, 18336@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 22 18:10:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jG473-000VxB-9R for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Mar 2020 18:10:13 +0100 Original-Received: from localhost ([::1]:48304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jG472-00033L-A1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Mar 2020 13:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49811) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jG46t-00033E-Cg for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2020 13:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jG46s-0000zP-EF for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2020 13:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jG46s-0000zG-B5 for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2020 13:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jG46s-0007L2-5P for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2020 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Mar 2020 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18336 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18336-submit@debbugs.gnu.org id=B18336.158489699328187 (code B ref 18336); Sun, 22 Mar 2020 17:10:02 +0000 Original-Received: (at 18336) by debbugs.gnu.org; 22 Mar 2020 17:09:53 +0000 Original-Received: from localhost ([127.0.0.1]:50867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jG46j-0007KZ-5w for submit@debbugs.gnu.org; Sun, 22 Mar 2020 13:09:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jG46h-0007KN-Pw for 18336@debbugs.gnu.org; Sun, 22 Mar 2020 13:09:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jG46c-0000wQ-Ex; Sun, 22 Mar 2020 13:09:46 -0400 Original-Received: from [176.228.60.248] (port=2213 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jG46U-00006R-M0; Sun, 22 Mar 2020 13:09:42 -0400 In-Reply-To: <87r1xkjsvf.fsf@gmail.com> (message from Noam Postavsky on Sun, 22 Mar 2020 11:45:24 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177627 Archived-At: > From: Noam Postavsky > Cc: dak@gnu.org, stefan@marxist.se, 18336@debbugs.gnu.org > Date: Sun, 22 Mar 2020 11:45:24 -0400 > > > Isn't it better to check whether the file is already locked? That > > way, we don't need any (error-prone) heuristics for when it's okay to > > ask the question and when it isn't. > > If I understand the code correctly, lock_file() already checks this (the > '&& !NILP (Ffile_exists_p (fn))' part), but takes the wrong action in > that case. So I'm not sure what we should do differently. AFAIU, 'fn' in lock_file is the file we want to lock, not the file we create to indicate the lock. Am I missing something?