From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40687: Missing right border on composed text used in 'display property Date: Thu, 23 Apr 2020 18:48:09 +0300 Message-ID: <83d07ycifa.fsf@gnu.org> References: <25b96bf7-a166-9d82-351d-1cfea7cec4f2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="101119"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40687@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 23 19:16:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRfSs-000QDP-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Apr 2020 19:16:42 +0200 Original-Received: from localhost ([::1]:46058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRe7x-0003H1-Ig for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Apr 2020 11:51:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58044) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRe67-0007L2-3K for bug-gnu-emacs@gnu.org; Thu, 23 Apr 2020 11:49:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRe63-00021m-9C for bug-gnu-emacs@gnu.org; Thu, 23 Apr 2020 11:49:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRe62-00021V-9h for bug-gnu-emacs@gnu.org; Thu, 23 Apr 2020 11:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRe62-0001Gt-5o for bug-gnu-emacs@gnu.org; Thu, 23 Apr 2020 11:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Apr 2020 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40687 X-GNU-PR-Package: emacs Original-Received: via spool by 40687-submit@debbugs.gnu.org id=B40687.15876569144845 (code B ref 40687); Thu, 23 Apr 2020 15:49:02 +0000 Original-Received: (at 40687) by debbugs.gnu.org; 23 Apr 2020 15:48:34 +0000 Original-Received: from localhost ([127.0.0.1]:55762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRe5a-0001G5-02 for submit@debbugs.gnu.org; Thu, 23 Apr 2020 11:48:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRe5Y-0001Fr-6O for 40687@debbugs.gnu.org; Thu, 23 Apr 2020 11:48:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49552) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRe5S-0001b3-SF; Thu, 23 Apr 2020 11:48:26 -0400 Original-Received: from [176.228.60.248] (port=4344 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jRe5R-00079r-L6; Thu, 23 Apr 2020 11:48:26 -0400 In-Reply-To: <25b96bf7-a166-9d82-351d-1cfea7cec4f2@gmail.com> (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel on Fri, 17 Apr 2020 15:44:36 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178861 Archived-At: > From: Clément Pit-Claudel > Date: Fri, 17 Apr 2020 15:44:36 -0400 > > With the following sample code, I observe the results shown in the attached image. The first two "ab" have a border, but the last one only has three-quarters of its border: the right side is missing. > > (defface my-button > '((t :box(:line-width -4 :style released-button) > :background"lightgrey":foreground"black")) > "Button face") > > (with-current-buffer (get-buffer-create "button") > (insert "\n") > (insert (propertize "ab" 'face 'my-button)) > (insert " ") > (insert (propertize (compose-chars ?a '(Br . Bl) ?b) 'face 'my-button)) > (insert " ") > (insert (propertize "ab" 'display (compose-chars ?a '(Br . Bl) ?b) 'face 'my-button)) > (insert " ") > (pop-to-buffer-same-window (current-buffer))) Thanks, should be fixed now. FTR, a recipe to test more fully display of composed text with a :box face is below. I found quite a few problems with this, especially when the text in the boxed face ends with a composed character. They should be fixed now on the master branch. I tested this fully only on MS-Windows; could someone please use the recipe below to verify the display looks correctly also on X and on NS? Note that what appears below to be LATIN SMALL LETTER A WITH ACUTE is not a single character, but 2 characters that are composed into a single glyph. (defface my-button '((t :box(:line-width -4 :style released-button) :background"lightgrey":foreground"black")) "Button face") (with-current-buffer (get-buffer-create "button") (insert "\n") (insert " ") (insert (propertize "ab" 'face 'my-button)) (insert " ") (insert "\n") (insert " ") (insert (propertize (compose-chars ?a '(Br . Bl) ?b) 'face 'my-button)) (insert " ") (insert "\n") (insert " ") (insert (propertize "ab" 'display (compose-chars ?a '(Br . Bl) ?b) 'face 'my-button)) (insert " ") (insert "\n") (insert " ") (insert (propertize "xá" 'face 'my-button)) (insert " ") (insert "\n") (insert " ") (insert (propertize "Khmer (ភាសាខ្មែរ) ជំរាបសួរ" 'face 'my-button)) (insert " ") (pop-to-buffer-same-window (current-buffer)))