From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42931: 27.1; json-pretty-print-buffer on ~2MB line causes core dump Date: Thu, 20 Aug 2020 16:39:26 +0300 Message-ID: <83d03lcu7l.fsf@gnu.org> References: <0b9da4d7-ca24-8e00-d49f-7630e42abe89@orcon.net.nz> <87364i2039.fsf@gnus.org> <831rk2eka9.fsf@gnu.org> <87imddwiy0.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31774"; mail-complaints-to="usenet@ciao.gmane.io" Cc: psainty@orcon.net.nz, 42931@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 20 15:40:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8knY-0008C1-Gl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 15:40:08 +0200 Original-Received: from localhost ([::1]:52534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8knX-00050o-Eg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 09:40:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8knR-00050U-UH for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 09:40:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8knR-000354-LH for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 09:40:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8knR-0000mf-J7 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 09:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 13:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42931 X-GNU-PR-Package: emacs Original-Received: via spool by 42931-submit@debbugs.gnu.org id=B42931.15979307902992 (code B ref 42931); Thu, 20 Aug 2020 13:40:01 +0000 Original-Received: (at 42931) by debbugs.gnu.org; 20 Aug 2020 13:39:50 +0000 Original-Received: from localhost ([127.0.0.1]:41998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8knG-0000mC-9s for submit@debbugs.gnu.org; Thu, 20 Aug 2020 09:39:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8kn6-0000lp-Tk for 42931@debbugs.gnu.org; Thu, 20 Aug 2020 09:39:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41077) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8kn0-00033l-QD; Thu, 20 Aug 2020 09:39:34 -0400 Original-Received: from [176.228.60.248] (port=2312 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k8kn0-0000DI-9W; Thu, 20 Aug 2020 09:39:34 -0400 In-Reply-To: <87imddwiy0.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 20 Aug 2020 15:22:31 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185689 Archived-At: > From: Lars Ingebrigtsen > Cc: psainty@orcon.net.nz, 42931@debbugs.gnu.org > Date: Thu, 20 Aug 2020 15:22:31 +0200 > > Eli Zaretskii writes: > > > looks like stack overflow? I guess the recursive nature of compareseq > > is got to cause this at some point? > > Yup. > > I'm not sure what to do about it, though. One easy way to "fix this" > would be to not use replace-region-contents in json-pretty-print if the > region is very large... but that's kinda just wallpapering over the > problem. > > replace-region-contents itself could decide to not do all its fancy > stuff if the region is very large, and just replace the contents in the > normal way instead? compareseq is a Gnulib module, so maybe its implementation could be fixed to bail out when the recursion becomes too deep?