From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 583cb26 2/3: Improve accuracy in string-replace description (bug#43598) Date: Tue, 29 Sep 2020 05:37:18 +0300 Message-ID: <83d025l34x.fsf@gnu.org> References: <20200927124520.25321.62354@vcs0.savannah.gnu.org> <20200927124522.BA20F207E0@vcs0.savannah.gnu.org> <9B45E488-F245-4A94-A492-C60B617A734B@acm.org> <50bea60b-b70b-4a80-b85b-0c9283a033de@default> <83o8lplu2v.fsf@gnu.org> <83k0wdlqj8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28936"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, rpluim@gmail.com, drew.adams@oracle.com, emacs-devel@gnu.org To: John Yates Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 29 04:38:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kN5Wk-0007Qm-QP for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Sep 2020 04:38:02 +0200 Original-Received: from localhost ([::1]:48956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kN5Wj-0004FD-PA for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Sep 2020 22:38:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kN5WE-0003oP-3t for emacs-devel@gnu.org; Mon, 28 Sep 2020 22:37:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57242) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kN5WD-0008Nk-Px; Mon, 28 Sep 2020 22:37:29 -0400 Original-Received: from [176.228.60.248] (port=3442 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kN5WC-0003W7-OE; Mon, 28 Sep 2020 22:37:29 -0400 In-Reply-To: (message from John Yates on Mon, 28 Sep 2020 18:36:24 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256656 Archived-At: > From: John Yates > Date: Mon, 28 Sep 2020 18:36:24 -0400 > Cc: Drew Adams , Robert Pluim , > Mattias EngdegÄrd , > Emacs developers > > On Mon, Sep 28, 2020 at 2:12 PM Eli Zaretskii wrote: > > > > > What do you find extremely confusing about it? > > > > The "equal" part. > > Return a string equivalent to @var{instring} with every occurence > of @var{fromstring} replaced by @var{tostring}. Thanks, this is better. But "equivalent" is too vague to be useful. What's wrong with the below? That's the natural way I'd say that. Replace every occurrence of FROMSTRING with TOSTRING in INSTRING, and return the result.