From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Tue, 08 Dec 2020 18:11:17 +0200 Message-ID: <83czzk6zx6.fsf@gnu.org> References: <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <87h7ox71xc.fsf@gnus.org> <874kkx6zwj.fsf@gnus.org> <87zh2p5ksl.fsf@gnus.org> <87r1o15ifl.fsf@gnus.org> <87eek15gaf.fsf@gnus.org> <83360g8huk.fsf@gnu.org> <87r1o0gwum.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16629"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ghe@sdf.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 08 17:14:06 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmfcs-0004HZ-JI for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 17:14:06 +0100 Original-Received: from localhost ([::1]:46596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmfcr-0005Oz-Kl for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 11:14:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmfaH-0003u7-Po for emacs-devel@gnu.org; Tue, 08 Dec 2020 11:11:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53351) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmfaF-0003ia-GZ; Tue, 08 Dec 2020 11:11:23 -0500 Original-Received: from [176.228.60.248] (port=4025 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kmfaE-0007Ml-OH; Tue, 08 Dec 2020 11:11:23 -0500 In-Reply-To: <87r1o0gwum.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 08 Dec 2020 16:07:29 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260564 Archived-At: > From: Lars Ingebrigtsen > Cc: ghe@sdf.org, emacs-devel@gnu.org > Date: Tue, 08 Dec 2020 16:07:29 +0100 > > Eli Zaretskii writes: > > > What will this do when the image file on disk changes? AFAIU, the > > current implementation will use the new image for the tool bar on the > > next redisplay opportunity, but this change will make us continue > > using the cached one? > > Yes. Changing toolbar image file contents is such a rare action that > it's not worth making Emacs recheck them on redisplay. All we need to do is stat the file, and reload it if its time stamp or size changed. Why is that a problem? If we don't do that, we are making an incompatible change, and I don't see a reason for doing that unconditionally.