From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property Date: Sun, 13 Dec 2020 17:05:02 +0200 Message-ID: <83czzdeogx.fsf@gnu.org> References: <83o8iyerpi.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2322"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Evgeny Zajcev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 13 16:06:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koSxK-0000RI-Ib for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Dec 2020 16:06:38 +0100 Original-Received: from localhost ([::1]:44030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koSxJ-00024S-LA for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Dec 2020 10:06:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koSw0-00011s-FK for emacs-devel@gnu.org; Sun, 13 Dec 2020 10:05:16 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36270) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koSvz-0004sf-T0; Sun, 13 Dec 2020 10:05:15 -0500 Original-Received: from [176.228.60.248] (port=2758 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1koSvy-0006dx-Q6; Sun, 13 Dec 2020 10:05:15 -0500 In-Reply-To: (message from Evgeny Zajcev on Sat, 12 Dec 2020 23:42:36 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260762 Archived-At: > From: Evgeny Zajcev > Date: Sat, 12 Dec 2020 23:42:36 +0300 > Cc: emacs-devel > > > > +@defun svg-embed-base-uri-image svg relative-filename &rest args > > > +To @var{svg} add an embedded (raster) image placed at > > > +@var{relative-filename}. @var{relative-filename} is searched inside > > > +@code{file-name-directory} of the @code{:base-uri} svg image property. > > > > This is the only place in the manual where the :base-uri attribute is > > mentioned. Can we please add some minimal description of what that > > attribute does and how it is useful? > > This is only function, where `:base-uri` could be useful Then I think its documentation should say something about what a "base URI" is. > > > +This improves the performance of embedding large images. > > > > What is "this" that improves the performance, and how does it do so? > > > > "this" - having support for `:base_uri` Yes, but _why_ does having the base URI improve the performance? > We should at least hint at the improvement, without that this sentence > > sounds puzzling. > > > > > I'll try my best in rewording this, however take into account that I'm very > bad at wording in English. Maybe it is better for someone else to write > docs for it? Just explain it in your words, and I will reword if needed. > I'll compose patch you want a bit later Thanks in advance.