From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] New with-file-buffer macro Date: Thu, 31 Dec 2020 21:48:17 +0200 Message-ID: <83czyphi4e.fsf@gnu.org> References: <87lfdddc0a.fsf@alphapapa.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27733"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 31 20:49:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kv3x1-00077G-FY for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Dec 2020 20:49:35 +0100 Original-Received: from localhost ([::1]:38828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kv3x0-00089R-GD for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Dec 2020 14:49:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kv3w7-0007iV-KP for emacs-devel@gnu.org; Thu, 31 Dec 2020 14:48:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56178) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kv3w7-0001lu-7E; Thu, 31 Dec 2020 14:48:39 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2608 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kv3w6-0004oj-Jj; Thu, 31 Dec 2020 14:48:39 -0500 In-Reply-To: <87lfdddc0a.fsf@alphapapa.net> (message from Adam Porter on Thu, 31 Dec 2020 13:13:57 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262197 Archived-At: > From: Adam Porter > Date: Thu, 31 Dec 2020 13:13:57 -0600 > > (let ((coding-system-for-write buffer-file-coding-system)) > (with-file-buffer (expand-file-name (concat name "-readme.txt") > package-build-archive-dir) > (:insert nil :write t :overwrite t) The binding for coding-system-for-write will pick up the value from the wrong buffer, won't it? In general, it looks to me like this macro is not very useful: it basically saves you two function calls. Is it really such a big deal? Most of the churn with the paradigm of reading a file and doing something with it is not in these two function calls, it is elsewhere, and what your macro does is just leave all of those tedious details to the user, just using a different syntax (plist instead of setting or binding variables).