all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jason Kim <jason.w.kim@icloud.com>
Cc: jason.kim@revtera.com, michael.albinus@gmx.de,
	shivers@cs.cmu.edu, emacs-devel@gnu.org
Subject: Re: Small shell-mode patch to handle auto-cd (e.g. shells like zsh)
Date: Sat, 15 May 2021 11:20:11 +0300	[thread overview]
Message-ID: <83cztsxvb8.fsf@gnu.org> (raw)
In-Reply-To: <6cb49320-ca9e-9212-13c8-78aa0a4f7dde@icloud.com> (message from Jason Kim on Fri, 7 May 2021 09:51:08 -0700)

> Cc: emacs-devel@gnu.org, shivers@cs.cmu.edu, jason.kim@revtera.com
> From: Jason Kim <jason.w.kim@icloud.com>
> Date: Fri, 7 May 2021 09:51:08 -0700
> 
> Hi, enclosed is what I hope is an acceptable git-format-patch for this 
> tiny change.
> 
> If not, please let me know how to fix!

Applying these patches produces the following byte-compilation
warnings:

   ELC      shell.elc

 In toplevel form:
 shell.el:324:1: Warning: defcustom for `shell-has-auto-cd' fails to specify
     type
 shell.el:324:1: Warning: custom-declare-variable `shell-has-auto-cd' docstring
     wider than 80 characters

In addition, please provide a :version tag for the new defcustom.

And finally, the commit log message should include ChangeLog-style
description of the file(s) and functions/variables which were affected
by the changes, see the existing log messages and the advice in
CONTRIBUTE for more details.

Please fix those minor nits, and then we will be able to install the
changes.

Thanks.



  reply	other threads:[~2021-05-15  8:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 19:55 Small shell-mode patch to handle auto-cd (e.g. shells like zsh) Jason Kim
2021-05-06  8:10 ` Michael Albinus
2021-05-06  8:23 ` Eli Zaretskii
2021-05-07 16:35   ` Jason Kim
2021-05-07 16:51     ` Jason Kim
2021-05-15  8:20       ` Eli Zaretskii [this message]
2021-05-24 17:15         ` Jason Kim
2021-05-24 17:20           ` Jason Kim
2021-05-25  7:38             ` Michael Albinus
2021-05-27 17:09               ` Jason Kim
2021-06-09 11:03                 ` Michael Albinus
2021-05-07 17:39     ` Michael Albinus
2021-05-08  6:36     ` Eli Zaretskii
2021-05-08 16:39       ` Jason Kim
2021-05-08 16:48         ` Eli Zaretskii
2021-05-08 17:19           ` Jason Kim
2021-05-08 17:58             ` Jason Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cztsxvb8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jason.kim@revtera.com \
    --cc=jason.w.kim@icloud.com \
    --cc=michael.albinus@gmx.de \
    --cc=shivers@cs.cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.