From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Inadequate coding in hack-elisp-shorthands Date: Fri, 01 Oct 2021 08:51:18 +0300 Message-ID: <83czopfg2x.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32556"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 01 07:52:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWBTc-0008GR-FR for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Oct 2021 07:52:56 +0200 Original-Received: from localhost ([::1]:54082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWBTa-0005WN-ML for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Oct 2021 01:52:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWBSK-0004l0-CN for emacs-devel@gnu.org; Fri, 01 Oct 2021 01:51:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42608) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWBSJ-0003jG-GL; Fri, 01 Oct 2021 01:51:35 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWBSJ-0002LF-3m; Fri, 01 Oct 2021 01:51:35 -0400 In-Reply-To: (message from Alan Mackenzie on Thu, 30 Sep 2021 20:35:17 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275949 Archived-At: > Date: Thu, 30 Sep 2021 20:35:17 +0000 > From: Alan Mackenzie > > In emacs -Q in the emacs-28 branch, create the following two line file, > foobar.el, and try to load it: > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > (defvar foo-baz "foobar-baz") > FOOBARELISP-SHORTHANDS: (("foo" . "foobar"))) > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > This will throw an error, but that isn't important. > > What is important is that the symbol foobar-baz is created by the > elisp-shorthands facility. > > This shouldn't happen since: > 1/- There is no Local Variables section. > 2/- There is no variable elisp-shorthands in that non-existent section. > > The following errors are evident in hack-elisp-shorthands: > 1/- The code doesn't check for a correctly formatted Local Variables > section. > 2/- The code, even if it did check, would only check the last 3000 bytes > in the file. The section can occur anywhere in the last 3000 > CHARACTERS. > 3/- The code doesn't do a case-sensitive search for "elisp-shorthands". > 4/- The code doesn't check for "elisp-shorthands" being a complete > symbol. > 5/- The code doesn't even check that "elisp-shorthands" is in a comment. > > I would suggest that these errors be corrected. I would also suggest > that the entire code and documentation for this new facility be > carefully reviewed by somebody who isn't the original author. Thanks, but why isn't this a full-blown bug report, submitted to debbugs?