From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 05 Feb 2022 20:31:44 +0200 Message-ID: <83czk117xr.fsf@gnu.org> References: <6a5bb5a08b6337d733c5@heytings.org> <83leyq3kfk.fsf@gnu.org> <83a6f631k3.fsf@gnu.org> <838ruq2z5t.fsf@gnu.org> <8335kx3h85.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2460"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, gregory@heytings.org, emacs-devel@gnu.org, larsi@gnus.org, mattiase@acm.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 05 19:33:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGPs4-0000SN-47 for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Feb 2022 19:33:16 +0100 Original-Received: from localhost ([::1]:55788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGPs2-0007C1-Rs for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Feb 2022 13:33:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGPqw-0006VB-7c for emacs-devel@gnu.org; Sat, 05 Feb 2022 13:32:06 -0500 Original-Received: from [2001:470:142:3::e] (port=39500 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGPqu-0005Vj-Qg; Sat, 05 Feb 2022 13:32:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=O52rHxvAU5g5vszls5GfcX5X0V04y6jFYw02pyqZ0Hg=; b=HLUl4ep61uAM BK2e1Tg9sD4m6dYUkOW2GZp9T2O4wJpZrD4MMijXbiSe40HzNIXK2ytx1WYqxdyaURH8cGh3C+NYv E2842acoIa71VzlwC0n7jwz6ZpSszI4sDi3wVdiPzQ2H007g5wnfOzaDMCxNiXJzoKS8JzkGMweMk 3GGxMrGUfBM61kiQvzO3QF6H5SjxzO5o7ihRxyFP3BnNymDAc8FXJDewFAM4Gh1z8u4Z2L0T0LtyN 2wwFEjuGeWNp6/KF1tQ1/IBA+2VjDfAYH9cTlqbsxVsAdlVZuqZ+dEn5IXZYlqO1E4G2jwRAMdt9Z s4EbR5KevHnBrujRALRIlA==; Original-Received: from [87.69.77.57] (port=4717 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGPqu-0006z7-9F; Sat, 05 Feb 2022 13:32:04 -0500 In-Reply-To: (message from Stefan Monnier on Sat, 05 Feb 2022 13:04:36 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285910 Archived-At: > From: Stefan Monnier > Cc: acm@muc.de, gregory@heytings.org, mattiase@acm.org, larsi@gnus.org, > emacs-devel@gnu.org > Date: Sat, 05 Feb 2022 13:04:36 -0500 > > >> BTW, currently, it's not just `EQ` that's slower but also `XSYMBOL` and > >> `SYMBOLP`. > > Where's the data which says what functions/macros became slower with > > this change? > > Nowhere. It's just that its code has gotten slightly more complex (an > additional test or two). As I said, I don't know if it ever has any > measurable impact. I just mentioned it for completeness's sake. I think it's high time we actually measured the impact by using perf. Otherwise this discussion is just a lot of hand-waving and "I said, he said" kind of argument. We will never be able to establish whether the slowdown is real in actual Emacs usage or just in micro-benchmarks.