From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding
 systems
Date: Sun, 13 Feb 2022 15:00:23 +0200
Message-ID: <83czjqrkew.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="7687"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Po Lu <luangruo@yahoo.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 13 14:05:02 2022
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1nJEYm-0001n5-Kp
	for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 14:05:00 +0100
Original-Received: from localhost ([::1]:47034 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1nJEYl-0003Ty-2C
	for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 08:04:59 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:36468)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1nJEUR-0002EK-KI
 for emacs-devel@gnu.org; Sun, 13 Feb 2022 08:00:35 -0500
Original-Received: from [2001:470:142:3::e] (port=34980 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nJEUP-0005rZ-HO; Sun, 13 Feb 2022 08:00:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to:
 references; bh=Ba2H2Vsqdo2hvCVFCt27mfb16VmiID65SxO6Rz+qk3o=; b=mq8BZLEe5cpoYA
 dCuy0rqtLmZGzi7wAs3Q82gm2jEea8BHkdel180hJPE6QWIn5gYvNukLZEQp7ZKRKH8W+yPU3ghl0
 QzYZdLw5s1qWlZ1NVERcTvYYAe66koZGAnWf9f3b7yYEyqZwpP9VMOcCABhz7wSj0LyHVUfWd14mu
 INuuCZkf1KUcBlh3S2brUCrMhIdRzMSv7wv7EhCS/q4txZnu6dLj2+xlnhuKINNZw82/BgOgDSWfD
 c3ELpgjWIquWIGG/nCQiqobfMKhCkvpOfgFdZXLSRhs3M9gT23iV19iZgoyaqADaV7DopyZvoQx/w
 GUg7BaMFqzqPVFap3cvw==;
Original-Received: from [87.69.77.57] (port=2254 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nJEUN-0005XK-C3; Sun, 13 Feb 2022 08:00:29 -0500
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:286210
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/286210>

First, we don't use "illegal" in these cases, we use "invalid":
there's nothing against any law in using bad values of some variables.

More importantly, why punting in these cases is the best possible
solution? why not fall back to some reasonable encoding instead?

And how come locale-coding-system is not a valid coding-system there
in the first place?