From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54715: 28.0.92; crash when X server died Date: Tue, 05 Apr 2022 15:16:10 +0300 Message-ID: <83czhvened.fsf@gnu.org> References: <87tub8v94y.fsf@redhat.com> <87ilro5ohc.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3809"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raeburn@redhat.com, 54715@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 05 14:17:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbi7l-0000jD-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Apr 2022 14:17:29 +0200 Original-Received: from localhost ([::1]:51074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbi7k-0008Lk-5S for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Apr 2022 08:17:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbi7L-0008Kr-7e for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 08:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbi7J-0007xd-RN for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 08:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbi7J-0002fJ-ND for bug-gnu-emacs@gnu.org; Tue, 05 Apr 2022 08:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Apr 2022 12:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54715 X-GNU-PR-Package: emacs Original-Received: via spool by 54715-submit@debbugs.gnu.org id=B54715.164916097510155 (code B ref 54715); Tue, 05 Apr 2022 12:17:01 +0000 Original-Received: (at 54715) by debbugs.gnu.org; 5 Apr 2022 12:16:15 +0000 Original-Received: from localhost ([127.0.0.1]:54003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbi6Y-0002dj-T7 for submit@debbugs.gnu.org; Tue, 05 Apr 2022 08:16:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbi6X-0002dH-Ch for 54715@debbugs.gnu.org; Tue, 05 Apr 2022 08:16:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbi6S-0005zy-56; Tue, 05 Apr 2022 08:16:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Fde+dDWNxsGh3ATvJA7VeeeRQNuuw1RDAHOKDkqld9I=; b=MzfnPeLuklKP uC4onyD+keEqKKtfk6j7nhibOCAawBoSqszL8z69NmVE55JOTT2hTjOj547/VI5lA/FD2R8trj2xC ODLF1PeClUG3KRW19BqhLBAeOcfM/AHYjZQfT8Wp77tPYM0K6SLTENIRZMNcbKaBiTZbvqxp7cGS0 od7Xi9O/rAnwFuN4CW0LlCuGBTypChd9jYsubfU5BqJnYTHs6uMYqsouYtSf4y8uJ0aRGhttQmeDK yW9Z8Ah5QewnwMMKqj8AgRRsUfJk3YBYprkpbbhiBdUjE5T1KfLrcdIyblFggXaz7ePnY3vvkf/nC ZZJz4VvkA//z/kLcQZnyZg==; Original-Received: from [87.69.77.57] (port=2674 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbi6R-0005OI-1i; Tue, 05 Apr 2022 08:16:07 -0400 In-Reply-To: <87ilro5ohc.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229439 Archived-At: > Cc: 54715@debbugs.gnu.org > Date: Tue, 05 Apr 2022 09:05:19 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > #28 0x0000000000422866 in x_connection_closed (dpy=dpy@entry=0x511fc50, error_message=error_message@entry=0x7ffde15e78e8 "Connection lost to X server ':0.0'", ioerror=ioerror@entry=true) at ../../src/xterm.c:10240 > > x_connection_closed binds inhibit-redisplay to t, so redisplay cannot do > anything interesting inside. True. > > #12 0x00000000004202a3 in redisplay_internal () at ../../src/xdisp.c:15633 > > But this frame shows that it did try to do something, and aborted. It looks like it aborted trying to do nothing ;-) > Unfortunately, I don't see anything interesting at line 15633 in Emacs > 28. I do see something interesting (did you look in 28.0.92 sources?): /* No redisplay if running in batch mode or frame is not yet fully initialized, or redisplay is explicitly turned off by setting Vinhibit_redisplay. */ if ((FRAME_INITIAL_P (SELECTED_FRAME ()) <<<<<<<<<<<<<<<<<<<<<<<<< && redisplay_skip_initial_frame) || !NILP (Vinhibit_redisplay)) return; Crystal ball says something is wrong with SELECTED_FRAME, and that causes the abort. My guess would be that Ken's kill-emacs-hooks were called when the X server died, and one of those hooks is unsafe, in that it causes redisplay. Or maybe we should refrain from calling redisplay_preserve_echo_area in delete-process when Emacs is shutting down due to a fatal error?