From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: master c3ab8f1: Improve buffer-match-p documentation
Date: Sat, 16 Apr 2022 11:40:53 +0300 [thread overview]
Message-ID: <83czhh1kve.fsf@gnu.org> (raw)
> diff --git a/lisp/window.el b/lisp/window.el
> index 2da2f8b..ea90995 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -7495,14 +7495,14 @@ display-buffer-fallback-action
> `display-buffer'.")
> (put 'display-buffer-fallback-action 'risky-local-variable t)
>
> -(defun display-buffer-assq-regexp (buffer-name alist action)
> +(defun display-buffer-assq-regexp (buffer-or-name alist action)
> "Retrieve ALIST entry corresponding to BUFFER-NAME.
> -This returns the cdr of the alist entry ALIST if either its key
> -satisfied a BUFFER-NAME per `buffer-match'. ACTION should have
> -the form of the action argument passed to `display-buffer'."
> +This returns the cdr of the alist entry ALIST if key and
> +buffer-or-name satisfy `buffer-match-p'. ACTION should have the
> +form of the action argument passed to `display-buffer'."
I fixed some minor issues with the modified doc string, but that still
leaves one question unanswered: what does this function return if no
alist entry satisfies buffer-match-p? That should be documented.
Thanks.
next reply other threads:[~2022-04-16 8:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 8:40 Eli Zaretskii [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-04-16 8:34 master c3ab8f1: Improve buffer-match-p documentation Eli Zaretskii
2022-04-16 8:26 Eli Zaretskii
2022-04-16 9:53 ` Philip Kaludercic
2022-04-16 11:00 ` Eli Zaretskii
2022-04-16 23:11 ` Philip Kaludercic
2022-04-17 6:42 ` Eli Zaretskii
2022-04-17 8:48 ` Philip Kaludercic
2022-04-17 11:30 ` Eli Zaretskii
2022-04-17 9:02 ` Philip Kaludercic
2022-04-17 11:31 ` Eli Zaretskii
2022-04-17 12:06 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czhh1kve.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.