From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2f31dbeadf: Also show mouse DND tooltip contents during interprogram drag-and-drop Date: Thu, 09 Jun 2022 10:03:27 +0300 Message-ID: <83czfi48u8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30514"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 09 09:12:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzCL2-0007nV-Ce for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Jun 2022 09:12:16 +0200 Original-Received: from localhost ([::1]:33138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzCL0-0001PY-Nr for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Jun 2022 03:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzCCZ-0007OF-EZ for emacs-devel@gnu.org; Thu, 09 Jun 2022 03:03:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzCCZ-0003Go-3h; Thu, 09 Jun 2022 03:03:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=3DeqUxnfhcPfhJQOW9kibCaEc8bUt/527Khj2sgtYrs=; b=Mu+M6xVBgK/7YK /Dd00nPXfXHtYRblKZSdw7Q0oiL0WiiSQUQeBUQn/78vcFVFqMPvt9WjFh6G2vxp6mZez3dKT16Fy FP/ZzhPjIzH6irauRsZwF4jiA2ACnZYi5JqgN++fWPd2wC04mQfFHYMUF7uvMPrzk36okgyGkiDIM AXMGfDsiS6PfV8uqtgzTwsjhMSdujnBqas9jEy9Ts8rDI3OhwDV0K92wRCJSjsWfLdyS2As6X4gin iJF0qzLzCnUfSyZYsbY43HCbETlrBRNYYs1s8JVMjDeIK6Cceq6EsN3P0Lr55CkkYmHnJDDyd78jf g0IjmBBrTeOFpJsGTQ8g==; Original-Received: from [87.69.77.57] (port=3487 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzCCY-0004Gj-EY; Thu, 09 Jun 2022 03:03:30 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290962 Archived-At: > branch: master > commit 2f31dbeadff0abc38ded5dd072df1ec179c49945 > Author: Po Lu > Commit: Po Lu > > Also show mouse DND tooltip contents during interprogram drag-and-drop > > * doc/lispref/frames.texi (Drag and Drop): Document new > parameter to `x-begin-drag'. > * lisp/mouse.el (mouse-drag-and-drop-region): Don't hide tooltip > when initiating interprogram drag-and-drop. > * lisp/term/haiku-win.el (x-begin-drag): > * lisp/term/ns-win.el (x-begin-drag): Add stubs for new > parameter. > * src/xfns.c (Fx_begin_drag): New parameter `follow-tooltip'. > (Fx_show_tip, syms_of_xfns): Add records of the last dx and dy > given to `x-show-tip'. > * src/xterm.c (x_clear_dnd_monitors): New function. > (x_dnd_begin_drag_and_drop): Save monitor attributes list if > appropriate. > (x_dnd_compute_tip_xy, x_dnd_update_tooltip_position): New > function. > (x_dnd_update_state, handle_one_xevent): Update tooltip position > during DND mouse movement. > (syms_of_xterm): Update staticpros. > * src/xterm.h: Update prototypes. Instead of recording tooltip's coordinates in static C variables (which then could cause potential problems with stale values), wouldn't it be better to just move the tip frame from Lisp when the mouse moves?