From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 56423@debbugs.gnu.org
Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode
Date: Thu, 07 Jul 2022 13:35:10 +0300 [thread overview]
Message-ID: <83czeh5hy9.fsf@gnu.org> (raw)
In-Reply-To: <87edyxz0as.fsf@web.de> (message from Michael Heerdegen on Thu, 07 Jul 2022 12:26:03 +0200)
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: 56423@debbugs.gnu.org
> Date: Thu, 07 Jul 2022 12:26:03 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Don't we need to make sure font-lock-major-mode is restored no matter
> > how wdired is exited, whether normally or abnormally?
>
> There are two official ways to return - `wdired-abort-changes' and
> `wdired-finish-edit' - both call `wdired-change-to-dired-mode' (which I
> modified).
>
> If a way of exiting doesn't call `wdired-change-to-dired-mode' your
> dired buffer would be broken afterwards AFAIU - you must call it to get
> rid of the modifications made by wdired.
It sounds like you described the "normal" ways of returning? I mostly
had in mind the "abnormal" ones, via one of the non-local exits. If
that is possible, we should set up unwind-protect form.
next prev parent reply other threads:[~2022-07-07 10:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 16:22 bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode Michael Heerdegen
2022-07-06 18:58 ` Michael Heerdegen
2022-07-06 19:19 ` Michael Heerdegen
2022-07-07 5:35 ` Eli Zaretskii
2022-07-07 10:26 ` Michael Heerdegen
2022-07-07 10:35 ` Eli Zaretskii [this message]
2022-07-07 11:14 ` Michael Heerdegen
2022-07-07 13:29 ` Eli Zaretskii
2022-07-07 15:09 ` Michael Heerdegen
2022-07-07 15:19 ` Michael Heerdegen
2022-07-07 16:03 ` Eli Zaretskii
2022-07-08 12:04 ` Michael Heerdegen
2022-07-08 12:22 ` Eli Zaretskii
2022-07-08 12:57 ` Michael Heerdegen
2022-07-08 12:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czeh5hy9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=56423@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.