From: Eli Zaretskii <eliz@gnu.org>
To: larsi@gnus.org, stefan@marxist.se
Cc: 57079@debbugs.gnu.org
Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good
Date: Tue, 09 Aug 2022 20:50:11 +0300 [thread overview]
Message-ID: <83czd9tigc.fsf@gnu.org> (raw)
In-Reply-To: <83fsi5tj31.fsf@gnu.org> (message from Eli Zaretskii on Tue, 09 Aug 2022 20:36:34 +0300)
> Cc: 57079@debbugs.gnu.org, stefan@marxist.se
> Date: Tue, 09 Aug 2022 20:36:34 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> But the above means that using seq-uniq with TESTFN nil is going to be
> unnecessarily slow from the get-go. People shouldn't use seq-uniq if
> they don't need a non-default TESTFN, because much faster
> implementations exist.
>
> IOW, since this bug is about speed, not anything else, I think making
> seq-uniq faster when TESTFN is nil isn't the right solution, the right
> solution is to point out that seq-uniq's purpose in this case is not
> to be a Speedy Gonzales.
In particular, it means that this:
commit 171b9314bf2b2ed1719f2451b527960e0a363a40
Author: Stefan Kangas <stefan@marxist.se>
AuthorDate: Tue Aug 9 14:29:12 2022 +0200
Commit: Stefan Kangas <stefan@marxist.se>
CommitDate: Tue Aug 9 17:58:15 2022 +0200
Replace utility functions with seq-uniq
* lisp/gnus/gnus-util.el (gnus-delete-duplicates):
* lisp/ibuf-ext.el (ibuffer-remove-duplicates): Redefine as
obsolete function alias for 'seq-uniq'. Update callers.
is incorrect: those callers should have been replaced with a faster
implementation than seq-uniq could ever become.
next prev parent reply other threads:[~2022-08-09 17:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 16:11 bug#57079: 29.0.50; Performance of seq-uniq is not very good Stefan Kangas
2022-08-09 16:47 ` Eli Zaretskii
2022-08-09 16:57 ` Lars Ingebrigtsen
2022-08-09 17:07 ` Eli Zaretskii
2022-08-09 17:21 ` Lars Ingebrigtsen
2022-08-09 17:45 ` Stefan Kangas
2022-08-09 17:18 ` Eli Zaretskii
2022-08-09 17:23 ` Lars Ingebrigtsen
2022-08-09 17:36 ` Eli Zaretskii
2022-08-09 17:50 ` Eli Zaretskii [this message]
2022-08-09 17:52 ` Lars Ingebrigtsen
2022-08-09 17:59 ` Eli Zaretskii
2022-08-09 18:03 ` Lars Ingebrigtsen
2022-08-09 18:16 ` Eli Zaretskii
2022-08-09 19:35 ` Juri Linkov
2022-08-12 13:16 ` Lars Ingebrigtsen
2022-08-12 23:59 ` Michael Heerdegen
2022-08-13 11:50 ` Lars Ingebrigtsen
2022-08-13 20:24 ` Michael Heerdegen
2022-08-15 6:39 ` Lars Ingebrigtsen
2022-08-15 23:37 ` Michael Heerdegen
2022-08-17 11:01 ` Lars Ingebrigtsen
2022-08-20 3:17 ` Michael Heerdegen
2022-08-20 9:19 ` Lars Ingebrigtsen
2022-08-20 15:13 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czd9tigc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=57079@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.